From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from [140.186.70.92] (port=42521 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1Oqm8o-0003Hq-EI for qemu-devel@nongnu.org; Wed, 01 Sep 2010 08:10:11 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.69) (envelope-from ) id 1Oqm8l-0003YK-Rp for qemu-devel@nongnu.org; Wed, 01 Sep 2010 08:10:10 -0400 Received: from mx1.redhat.com ([209.132.183.28]:15956) by eggs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1Oqm8l-0003Y8-Jd for qemu-devel@nongnu.org; Wed, 01 Sep 2010 08:10:07 -0400 Message-ID: <4C7E4297.5000804@redhat.com> Date: Wed, 01 Sep 2010 15:09:59 +0300 From: Avi Kivity MIME-Version: 1.0 References: <1283249237-31881-1-git-send-email-agraf@suse.de> <4C7E038E.9050407@redhat.com> <64ABF588-42FC-4B83-A1DD-74BEAD265909@suse.de> <4C7E3CF5.3080400@redhat.com> <4C7E3F85.8090201@redhat.com> <1D0E7834-57D9-4845-9329-141CD2443039@suse.de> <4C7E4262.2040905@redhat.com> In-Reply-To: <4C7E4262.2040905@redhat.com> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Subject: [Qemu-devel] Re: [RFC] KVM: PPC: Add level based interrupt logic List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Alexander Graf Cc: Marcelo Tosatti , qemu-devel List On 09/01/2010 03:09 PM, Avi Kivity wrote: > On 09/01/2010 02:58 PM, Alexander Graf wrote: >> >>> Why not limit it to ppc? Someone might call it by accident. >> How would you model it? Call kvm_arch_set_interrupt in hw/ppc.c? >> Which header would I define the call in? >> > > Well, eventually this finds its way to cpu code in target-ppc, no? > from there you can call a function in target-ppc/kvm.c without any > need for tricks. > > So just hack it there. > Another way to look at this: shouldn't this be the same for kvm and non-kvm? -- I have a truly marvellous patch that fixes the bug which this signature is too narrow to contain.