* [Qemu-devel] [PATCH] qemu-io: Make alloc output useful when nb_sectors=1
@ 2010-09-02 9:38 Stefan Hajnoczi
2010-09-02 10:02 ` [Qemu-devel] " Kevin Wolf
0 siblings, 1 reply; 2+ messages in thread
From: Stefan Hajnoczi @ 2010-09-02 9:38 UTC (permalink / raw)
To: qemu-devel; +Cc: Kevin Wolf, Stefan Hajnoczi
There is no indication whether or not the sector is allocated when
nb_sectors=1:
sector allocated at offset 64 KiB
This message is produced whether or not the sector is allocated.
Simply use the same message as the plural case, I don't think the
English is so broken that we need special case output here:
0/1 sectors allocated at offset 64 KiB
This change does not affect qemu-iotests since nb_sectors=1 is not used
there.
Signed-off-by: Stefan Hajnoczi <stefanha@linux.vnet.ibm.com>
---
qemu-io.c | 7 ++-----
1 files changed, 2 insertions(+), 5 deletions(-)
diff --git a/qemu-io.c b/qemu-io.c
index 2dbe20f..bd3bd16 100644
--- a/qemu-io.c
+++ b/qemu-io.c
@@ -1427,11 +1427,8 @@ alloc_f(int argc, char **argv)
cvtstr(offset, s1, sizeof(s1));
- if (nb_sectors == 1)
- printf("sector allocated at offset %s\n", s1);
- else
- printf("%d/%d sectors allocated at offset %s\n",
- sum_alloc, nb_sectors, s1);
+ printf("%d/%d sectors allocated at offset %s\n",
+ sum_alloc, nb_sectors, s1);
return 0;
}
--
1.7.1
^ permalink raw reply related [flat|nested] 2+ messages in thread* [Qemu-devel] Re: [PATCH] qemu-io: Make alloc output useful when nb_sectors=1
2010-09-02 9:38 [Qemu-devel] [PATCH] qemu-io: Make alloc output useful when nb_sectors=1 Stefan Hajnoczi
@ 2010-09-02 10:02 ` Kevin Wolf
0 siblings, 0 replies; 2+ messages in thread
From: Kevin Wolf @ 2010-09-02 10:02 UTC (permalink / raw)
To: Stefan Hajnoczi; +Cc: qemu-devel
Am 02.09.2010 11:38, schrieb Stefan Hajnoczi:
> There is no indication whether or not the sector is allocated when
> nb_sectors=1:
>
> sector allocated at offset 64 KiB
>
> This message is produced whether or not the sector is allocated.
>
> Simply use the same message as the plural case, I don't think the
> English is so broken that we need special case output here:
>
> 0/1 sectors allocated at offset 64 KiB
>
> This change does not affect qemu-iotests since nb_sectors=1 is not used
> there.
>
> Signed-off-by: Stefan Hajnoczi <stefanha@linux.vnet.ibm.com>
Thanks, applied to the block branch.
Kevin
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2010-09-02 10:03 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2010-09-02 9:38 [Qemu-devel] [PATCH] qemu-io: Make alloc output useful when nb_sectors=1 Stefan Hajnoczi
2010-09-02 10:02 ` [Qemu-devel] " Kevin Wolf
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).