From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from [140.186.70.92] (port=38003 helo=eggs.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1OrHBl-00005P-U3
	for qemu-devel@nongnu.org; Thu, 02 Sep 2010 17:19:18 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.69)
	(envelope-from <weil@mail.berlios.de>) id 1OrHBk-0008KT-66
	for qemu-devel@nongnu.org; Thu, 02 Sep 2010 17:19:17 -0400
Received: from moutng.kundenserver.de ([212.227.126.187]:60346)
	by eggs.gnu.org with esmtp (Exim 4.69)
	(envelope-from <weil@mail.berlios.de>) id 1OrHBj-0008K5-Rv
	for qemu-devel@nongnu.org; Thu, 02 Sep 2010 17:19:16 -0400
Message-ID: <4C8014CF.3060707@mail.berlios.de>
Date: Thu, 02 Sep 2010 23:19:11 +0200
From: Stefan Weil <weil@mail.berlios.de>
MIME-Version: 1.0
Subject: Re: [Qemu-devel] [PATCH] target-arm: Handle 'smc' as an undefined
	instruction
References: <20100902202731.GA23301@os.inf.tu-dresden.de>
In-Reply-To: <20100902202731.GA23301@os.inf.tu-dresden.de>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Adam Lackorzynski <adam@os.inf.tu-dresden.de>
Cc: qemu-devel@nongnu.org

Am 02.09.2010 22:27, schrieb Adam Lackorzynski:
> Handle smc as an undefined instruction instead of having it wrongly
> interpreted as some other one.
>
> Signed-off-by: Adam Lackorzynski<adam@os.inf.tu-dresden.de>
> ---
>   target-arm/translate.c |    6 +++++-
>   1 files changed, 5 insertions(+), 1 deletions(-)
>
> diff --git a/target-arm/translate.c b/target-arm/translate.c
> index 6fcdd7e..9b5d650 100644
> --- a/target-arm/translate.c
> +++ b/target-arm/translate.c
> @@ -6346,7 +6346,11 @@ static void disas_arm_insn(CPUState * env, DisasContext *s)
>               dead_tmp(tmp2);
>               store_reg(s, rd, tmp);
>               break;
> -        case 7: /* bkpt */
> +        case 7:
> +            /* SMC? */
> +            if ((insn&  0xfffffff0) == 0xe1600070)
> +              goto illegal_op;
>    

QEMU's CODING_STYLE requires {} here.


> +            /* bkpt */
>               gen_set_condexec(s);
>               gen_set_pc_im(s->pc - 4);
>               gen_exception(EXCP_BKPT);
>