From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from [140.186.70.92] (port=44668 helo=eggs.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1OrLUH-0003og-P6
	for qemu-devel@nongnu.org; Thu, 02 Sep 2010 21:54:42 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.69)
	(envelope-from <seto.hidetoshi@jp.fujitsu.com>) id 1OrLUG-0003Va-GJ
	for qemu-devel@nongnu.org; Thu, 02 Sep 2010 21:54:41 -0400
Received: from fgwmail7.fujitsu.co.jp ([192.51.44.37]:58029)
	by eggs.gnu.org with esmtp (Exim 4.69)
	(envelope-from <seto.hidetoshi@jp.fujitsu.com>) id 1OrLUF-0003Uw-UE
	for qemu-devel@nongnu.org; Thu, 02 Sep 2010 21:54:40 -0400
Received: from m2.gw.fujitsu.co.jp ([10.0.50.72])
	by fgwmail7.fujitsu.co.jp (Fujitsu Gateway) with ESMTP id
	o831sXsx019060 for <qemu-devel@nongnu.org> (envelope-from
	seto.hidetoshi@jp.fujitsu.com); Fri, 3 Sep 2010 10:54:34 +0900
Received: from smail (m2 [127.0.0.1])
	by outgoing.m2.gw.fujitsu.co.jp (Postfix) with ESMTP id 8D16D45DE55
	for <qemu-devel@nongnu.org>; Fri,  3 Sep 2010 10:54:33 +0900 (JST)
Received: from s2.gw.fujitsu.co.jp (s2.gw.fujitsu.co.jp [10.0.50.92])
	by m2.gw.fujitsu.co.jp (Postfix) with ESMTP id 60DB045DE57
	for <qemu-devel@nongnu.org>; Fri,  3 Sep 2010 10:54:33 +0900 (JST)
Received: from s2.gw.fujitsu.co.jp (localhost.localdomain [127.0.0.1])
	by s2.gw.fujitsu.co.jp (Postfix) with ESMTP id 44466E38002
	for <qemu-devel@nongnu.org>; Fri,  3 Sep 2010 10:54:33 +0900 (JST)
Received: from m106.s.css.fujitsu.com (m106.s.css.fujitsu.com [10.249.87.106])
	by s2.gw.fujitsu.co.jp (Postfix) with ESMTP id F2D141DB803A
	for <qemu-devel@nongnu.org>; Fri,  3 Sep 2010 10:54:32 +0900 (JST)
Message-ID: <4C805537.6080409@jp.fujitsu.com>
Date: Fri, 03 Sep 2010 10:53:59 +0900
From: Hidetoshi Seto <seto.hidetoshi@jp.fujitsu.com>
MIME-Version: 1.0
References: <1283187480-23563-1-git-send-email-cam@cs.ualberta.ca>
In-Reply-To: <1283187480-23563-1-git-send-email-cam@cs.ualberta.ca>
Content-Type: text/plain; charset=ISO-2022-JP
Content-Transfer-Encoding: 7bit
Subject: [Qemu-devel] Re: [PATCH] Use signed 16-bit values for ivshmem
	register writes
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Cam Macdonell <cam@cs.ualberta.ca>
Cc: "Hao, Xudong" <xudong.hao@intel.com>, qemu-devel@nongnu.org, kvm@vger.kernel.org

(2010/08/31 1:58), Cam Macdonell wrote:
> fixes gcc 4.1 warning
> 
> Signed-off-by: Cam Macdonell <cam@cs.ualberta.ca>
> ---
>  hw/ivshmem.c |    4 ++--
>  1 files changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/hw/ivshmem.c b/hw/ivshmem.c
> index bbb5cba..fa9c684 100644
> --- a/hw/ivshmem.c
> +++ b/hw/ivshmem.c
> @@ -181,8 +181,8 @@ static void ivshmem_io_writel(void *opaque, target_phys_addr_t addr,
>      IVShmemState *s = opaque;
>  
>      uint64_t write_one = 1;
> -    uint16_t dest = val >> 16;
> -    uint16_t vector = val & 0xff;
> +    int16_t dest = val >> 16;
> +    int16_t vector = val & 0xff;
>  
>      addr &= 0xfc;
>  

Since val is uint32_t, I think this change doesn't make sense.

Thanks,
H.Seto