From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from [140.186.70.92] (port=55802 helo=eggs.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1Osulv-0001Jl-2h
	for qemu-devel@nongnu.org; Tue, 07 Sep 2010 05:47:28 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.69)
	(envelope-from <kwolf@redhat.com>) id 1Osulo-0007Fk-Li
	for qemu-devel@nongnu.org; Tue, 07 Sep 2010 05:47:21 -0400
Received: from mx1.redhat.com ([209.132.183.28]:16694)
	by eggs.gnu.org with esmtp (Exim 4.69)
	(envelope-from <kwolf@redhat.com>) id 1Osulo-0007FK-FY
	for qemu-devel@nongnu.org; Tue, 07 Sep 2010 05:47:16 -0400
Message-ID: <4C860A2E.3070504@redhat.com>
Date: Tue, 07 Sep 2010 11:47:26 +0200
From: Kevin Wolf <kwolf@redhat.com>
MIME-Version: 1.0
Subject: Re: [Qemu-devel] [PATCH] raw-posix: improve detection of scsi-generic
	devices
References: <1283785562-31830-1-git-send-email-bernhard.kohl@nsn.com>
	<033BDB4B-79AA-4FFE-8105-AD870B57DAA8@suse.de>
	<20100907020448.GA1508@lst.de>
In-Reply-To: <20100907020448.GA1508@lst.de>
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 7bit
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Christoph Hellwig <hch@lst.de>
Cc: Bernhard Kohl <bernhard.kohl@nsn.com>, Alexander Graf <agraf@suse.de>, Bernhard Kohl <bernhard.kohl@gmx.net>, qemu-devel@nongnu.org

Am 07.09.2010 04:04, schrieb Christoph Hellwig:
> On Mon, Sep 06, 2010 at 05:39:00PM +0200, Alexander Graf wrote:
>>
>> On 06.09.2010, at 17:06, Bernhard Kohl wrote:
>>
>>> From: Bernhard Kohl <bernhard.kohl@gmx.net>
>>>
>>> Allow symbolic links which point to /dev/sgX devices.
>>
>> Couldn't you send an SG_IO test ioctl over and see if it works? I really dislike the whole file name magic matching.
> 
> You could, but the result would not be what you expect, given that every
> /dev/sd* device and more in Linux support it.
> 
> What we really need is to stop shoe-horning scsi pass through support
> into the block layer.  Once we finally get our generic thread offload
> facilily there is no need for it anymore at all, scsi-generic can
> simplify offload the SG_IO ioctl and be done with it.  I even have an
> old prototype for this, just waiting for the generic thread offload
> to get merged before resurrecting it.

Let's apply this patch for the time being then, and remove the code
altogether as soon as possible.

Kevin