From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from [140.186.70.92] (port=56856 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1OsyaP-0001iZ-A9 for qemu-devel@nongnu.org; Tue, 07 Sep 2010 09:51:46 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.69) (envelope-from ) id 1OsyaN-0003fi-RV for qemu-devel@nongnu.org; Tue, 07 Sep 2010 09:51:45 -0400 Received: from mx1.redhat.com ([209.132.183.28]:60186) by eggs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1OsyaN-0003fb-JF for qemu-devel@nongnu.org; Tue, 07 Sep 2010 09:51:43 -0400 Message-ID: <4C864365.30301@redhat.com> Date: Tue, 07 Sep 2010 16:51:33 +0300 From: Avi Kivity MIME-Version: 1.0 Subject: Re: [Qemu-devel] [PATCH 1/3] qemu-kvm: Invert svm-flag setting logic References: <1283858843-21330-1-git-send-email-joerg.roedel@amd.com> <1283858843-21330-2-git-send-email-joerg.roedel@amd.com> In-Reply-To: Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Alexander Graf Cc: Joerg Roedel , Marcelo Tosatti , qemu-devel@nongnu.org, kvm@vger.kernel.org On 09/07/2010 03:23 PM, Alexander Graf wrote: > > I think we should get rid of kvm_nested and -enable-nesting. Instead, we should enable the SVM bit in the "host" and "qemu64" cpu types, but not in "kvm64". This way users are safe to not use nested svm, but can choose to do so if they like. > > Also, it should be possible to do something like -cpu kvm64,flags=+svm. Without having to mess with -enable-nesting. I agree, -enable-nesting is redundant with -cpu ,+svm. -- error compiling committee.c: too many arguments to function