From: "H. Peter Anvin" <hpa@linux.intel.com>
To: Amos Kong <akong@redhat.com>
Cc: qemu-devel@nongnu.org, kvm@vger.kernel.org,
"H. Peter Anvin" <hpa@zytor.com>
Subject: [Qemu-devel] Re: [PATCH] [RFC] Add support for a USB audio device model
Date: Mon, 13 Sep 2010 14:07:43 -0700 [thread overview]
Message-ID: <4C8E929F.9000002@linux.intel.com> (raw)
In-Reply-To: <20100913205338.GA2607@z>
On 09/13/2010 01:53 PM, Amos Kong wrote:
>
> # patch -p1 < /tmp/usb-audio.patch
> # ./configure
> ...
> ...
> preadv support yes
> fdatasync yes
> uuid support no
> vhost-net support no
> Trace backend nop
> Trace output file trace-<pid>
> ./configure: 2276: Bad substitution
>
>
>> diff --git a/create_config b/create_config
>> index 0098e68..1caa25b 100755
>> --- a/create_config
>> +++ b/create_config
>> @@ -25,7 +25,7 @@ case $line in
>> CONFIG_AUDIO_DRIVERS=*)
>> drivers=${line#*=}
>> echo "#define CONFIG_AUDIO_DRIVERS \\"
>> - for drv in $drivers; do
>> + for drv in ${drivers//-/_}; do
>> echo " &${drv}_audio_driver,\\"
>> done
>> echo ""
>> @@ -39,10 +39,12 @@ case $line in
>> ;;
>> CONFIG_*=y) # configuration
>> name=${line%=*}
>> + name=${name//-/_}
>> echo "#define $name 1"
>> ;;
>> CONFIG_*=*) # configuration
>> name=${line%=*}
>> + name=${name//-/_}
>> value=${line#*=}
>> echo "#define $name $value"
>> ;;
Looks like ${.../...} is a bashism.
One can replace it with:
name=`echo "$name" | tr '-' '_'`
and
for drv in `echo "$drivers" | tr '-' '_'`; do
-hpa
prev parent reply other threads:[~2010-09-13 21:07 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-09-10 21:47 [Qemu-devel] [PATCH] [RFC] Add support for a USB audio device model H. Peter Anvin
2010-09-11 0:28 ` [Qemu-devel] " malc
2010-09-11 1:08 ` H. Peter Anvin
2010-09-11 2:47 ` H. Peter Anvin
2010-09-11 3:05 ` H. Peter Anvin
2010-09-11 13:53 ` malc
2010-09-11 17:09 ` H. Peter Anvin
2010-09-11 13:14 ` Alexander Graf
2010-09-11 18:29 ` H. Peter Anvin
2010-09-11 7:41 ` Stefan Hajnoczi
2010-09-12 5:20 ` H. Peter Anvin
2010-09-13 20:53 ` Amos Kong
2010-09-13 21:04 ` H. Peter Anvin
2010-09-14 1:37 ` Amos Kong
2010-09-14 5:56 ` H. Peter Anvin
2010-10-14 13:51 ` Mike Snitzer
2010-10-14 15:40 ` H. Peter Anvin
2010-10-14 16:18 ` Alon Levy
2010-10-14 17:43 ` H. Peter Anvin
2010-09-13 21:07 ` H. Peter Anvin [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4C8E929F.9000002@linux.intel.com \
--to=hpa@linux.intel.com \
--cc=akong@redhat.com \
--cc=hpa@zytor.com \
--cc=kvm@vger.kernel.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).