From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from [140.186.70.92] (port=48530 helo=eggs.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1OvW40-0007Tq-2N
	for qemu-devel@nongnu.org; Tue, 14 Sep 2010 10:00:53 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.69)
	(envelope-from <anthony@codemonkey.ws>) id 1OvW3y-0006FT-QR
	for qemu-devel@nongnu.org; Tue, 14 Sep 2010 10:00:47 -0400
Received: from mail-vw0-f45.google.com ([209.85.212.45]:37854)
	by eggs.gnu.org with esmtp (Exim 4.69)
	(envelope-from <anthony@codemonkey.ws>) id 1OvW3y-0006FN-NZ
	for qemu-devel@nongnu.org; Tue, 14 Sep 2010 10:00:46 -0400
Received: by vws19 with SMTP id 19so6197574vws.4
	for <qemu-devel@nongnu.org>; Tue, 14 Sep 2010 07:00:45 -0700 (PDT)
Message-ID: <4C8F800B.2090304@codemonkey.ws>
Date: Tue, 14 Sep 2010 09:00:43 -0500
From: Anthony Liguori <anthony@codemonkey.ws>
MIME-Version: 1.0
References: <1284471474-24989-1-git-send-email-Jes.Sorensen@redhat.com>
In-Reply-To: <1284471474-24989-1-git-send-email-Jes.Sorensen@redhat.com>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
Subject: [Qemu-devel] Re: [PATCH] Support T/t for guest memory sizes
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Jes.Sorensen@redhat.com
Cc: qemu-devel@nongnu.org

On 09/14/2010 08:37 AM, Jes.Sorensen@redhat.com wrote:
> From: Jes Sorensen<Jes.Sorensen@redhat.com>
>
> Signed-off-by: Jes Sorensen<Jes.Sorensen@redhat.com>
>    

anthony@titi:~/git/qemu$ grep "case 'G': case 'g':" *.c
monitor.c:                    case 'G': case 'g':
vl.c:            case 'G': case 'g':
vl.c:                case 'G': case 'g':

So there's more locations to fixup.  But while you're touching this 
code, it probably makes sense to add a str_to_bytes() function to 
cutils.c to make sure we accept things consistently for the future.

Regards,

Anthony Liguori


> ---
>   vl.c |    3 +++
>   1 files changed, 3 insertions(+), 0 deletions(-)
>
> diff --git a/vl.c b/vl.c
> index 3f45aa9..0663f2f 100644
> --- a/vl.c
> +++ b/vl.c
> @@ -2176,6 +2176,9 @@ int main(int argc, char **argv, char **envp)
>                   case 'G': case 'g':
>                       value<<= 30;
>                       break;
> +                case 'T': case 't':
> +                    value<<= 40;
> +                    break;
>                   default:
>                       fprintf(stderr, "qemu: invalid ram size: %s\n", optarg);
>                       exit(1);
>