From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from [140.186.70.92] (port=38669 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1OvWhs-0003wZ-DG for qemu-devel@nongnu.org; Tue, 14 Sep 2010 10:42:04 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.69) (envelope-from ) id 1OvWhq-0003QE-LZ for qemu-devel@nongnu.org; Tue, 14 Sep 2010 10:42:00 -0400 Received: from mx1.redhat.com ([209.132.183.28]:51401) by eggs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1OvWhq-0003Q7-Cq for qemu-devel@nongnu.org; Tue, 14 Sep 2010 10:41:58 -0400 Message-ID: <4C8F89B2.3010902@redhat.com> Date: Tue, 14 Sep 2010 16:41:54 +0200 From: Jes Sorensen MIME-Version: 1.0 References: <1284471474-24989-1-git-send-email-Jes.Sorensen@redhat.com> <4C8F800B.2090304@codemonkey.ws> In-Reply-To: <4C8F800B.2090304@codemonkey.ws> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Subject: [Qemu-devel] Re: [PATCH] Support T/t for guest memory sizes List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Anthony Liguori Cc: qemu-devel@nongnu.org On 09/14/10 16:00, Anthony Liguori wrote: > On 09/14/2010 08:37 AM, Jes.Sorensen@redhat.com wrote: >> From: Jes Sorensen >> >> Signed-off-by: Jes Sorensen >> > > anthony@titi:~/git/qemu$ grep "case 'G': case 'g':" *.c > monitor.c: case 'G': case 'g': > vl.c: case 'G': case 'g': > vl.c: case 'G': case 'g': > > So there's more locations to fixup. But while you're touching this > code, it probably makes sense to add a str_to_bytes() function to > cutils.c to make sure we accept things consistently for the future. Fair enough, I'll have a look. Cheers, Jes