From: Avi Kivity <avi@redhat.com>
To: Anthony Liguori <anthony@codemonkey.ws>
Cc: Kevin Wolf <kwolf@redhat.com>,
Stefan Hajnoczi <stefanha@gmail.com>,
qemu-devel <qemu-devel@nongnu.org>
Subject: Re: [Qemu-devel] qcow2 performance plan
Date: Tue, 14 Sep 2010 19:23:30 +0200 [thread overview]
Message-ID: <4C8FAF92.3090503@redhat.com> (raw)
In-Reply-To: <4C8FAC15.1020500@codemonkey.ws>
On 09/14/2010 07:08 PM, Anthony Liguori wrote:
>> Yes, I hit this too. So without this patch, it does serialize all
>> allocating writes?
>
>
> Yes, but my patch is not enough as it turns out.
>
> When dealing with O_DIRECT, we have to handle RMW on our own which
> means we need to serialize access to the same sector.
>
> The way we're planning on addressing this in the short term is to
> break the single allocator queue into a per-L2 table queue. So writes
> to the same L2 would be serialized but writes to different L2s would
> not be serialized.
>
So at least I read the code correctly.
The next step (also addressed in the qcow2 performance plan) is to batch
writes to L2. You'd actually expect to have many concurrent allocating
writes to one L2. The first is sent to disk, but the following ones
just mark the L2 dirty. When the write returns, it sees it's still
dirty and goes back to disk again.
--
error compiling committee.c: too many arguments to function
next prev parent reply other threads:[~2010-09-14 17:23 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-09-14 13:07 [Qemu-devel] qcow2 performance plan Avi Kivity
2010-09-14 13:43 ` Anthony Liguori
2010-09-14 15:11 ` Kevin Wolf
2010-09-14 15:20 ` Anthony Liguori
2010-09-14 15:47 ` Kevin Wolf
2010-09-14 16:03 ` Stefan Hajnoczi
2010-09-14 16:16 ` Anthony Liguori
2010-09-14 16:28 ` Avi Kivity
2010-09-14 17:08 ` Anthony Liguori
2010-09-14 17:23 ` Avi Kivity [this message]
2010-09-14 18:58 ` Anthony Liguori
2010-09-14 14:01 ` [Qemu-devel] " Kevin Wolf
2010-09-14 15:14 ` Stefan Hajnoczi
2010-09-14 15:25 ` [Qemu-devel] " Anthony Liguori
2010-09-14 16:30 ` Avi Kivity
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4C8FAF92.3090503@redhat.com \
--to=avi@redhat.com \
--cc=anthony@codemonkey.ws \
--cc=kwolf@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=stefanha@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).