Re: [Qemu-devel] [Bug 636315] [NEW] configure and build errors on Solaris 10 due to /bin/sh usage

[Michael Tokarev <mjt@tls.msk.ru>]

14.09.2010 20:41, blueswirl wrote:
> On Mon, Sep 13, 2010 at 8:49 AM, Michael Tokarev <mjt@tls.msk.ru> wrote:
[]
>>>>> diff --git a/tracetool b/tracetool
>>>>> index 534cc70..c7582bf 100755
>>>>> --- a/tracetool
>>>>> +++ b/tracetool
>>>>> @@ -48,7 +48,8 @@ get_argnames()
>>>>> {
>>>>>    local nfields field name
>>>>>    nfields=0
>>>>> -    for field in $(get_args "$1"); do
>>>>> +    args=get_args "$1"
>>>>> +    for field in "$args"; do
>>>>
>>>> This part yes. (I took the liberty of adding args to the local line above)
>>
>> Um.  Are you sure it works as expected?  I'm not at all shure.
>> There are 2 errors in the above patch:
[]
> Do you see any bug with the original?

The thing is - I've no idea what's the talk about.
There's no mentions of tracetool in 0.13.0-rc1 tarball.

> If the problem is in fact that Solaris' /bin/sh is not standards
> compliant, we shouldn't fix the script but instead make sure that the
> shell used to run tracetool is the compliant one.

Solaris's /bin/sh isn't exactly non-standard-compliant,
it's very limited.  In particular, $() construct weren't
in the standard for quite some time, and I'm not sure
it is now.

The usual idiom is to use backticks `` for this.  Only
in case of nested subshells or using case..esac (with
closing brases for individual cases) standard backticks
does not work.

/mjt