From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from [140.186.70.92] (port=52684 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1Ovt7w-0000uF-Pd for qemu-devel@nongnu.org; Wed, 15 Sep 2010 10:38:26 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.69) (envelope-from ) id 1Ovt7q-0006VR-FK for qemu-devel@nongnu.org; Wed, 15 Sep 2010 10:38:24 -0400 Received: from mx1.redhat.com ([209.132.183.28]:12423) by eggs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1Ovt7q-0006Ux-94 for qemu-devel@nongnu.org; Wed, 15 Sep 2010 10:38:18 -0400 Message-ID: <4C90DA98.2010807@redhat.com> Date: Wed, 15 Sep 2010 16:39:20 +0200 From: Michal Novotny MIME-Version: 1.0 Subject: Re: [Qemu-devel] [PATCH] serial: Update parameters after load References: <4C8E2B60.1010909@redhat.com> <20100915135356.GA29442@edde.se.axis.com> In-Reply-To: <20100915135356.GA29442@edde.se.axis.com> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: "Edgar E. Iglesias" Cc: "qemu-devel@nongnu.org" On 09/15/2010 03:53 PM, Edgar E. Iglesias wrote: > On Mon, Sep 13, 2010 at 03:47:12PM +0200, Michal Novotny wrote: > >> Hi, >> >> this is the patch to update serial port parameters after guest is >> already loaded. >> > Hi > > This patch didn't apply: > > % git am -s ~/.maildir/minovotn/ > Applying: serial: Update parameters after load > error: patch failed: hw/serial.c:674 > error: hw/serial.c: patch does not apply > Patch failed at 0001 serial: Update parameters after load > When you have resolved this problem run "git am --resolved". > If you would prefer to skip this patch, instead run "git am --skip". > To restore the original branch and stop patching run "git am --abort" > > >> Signed-off-by: Michal Novotny >> > ^^^^ > missing space > Hi, thanks. Nevetheless should there be a space between name and e-mail address? I didn't know what's right so if there should be a space please tell me to take care of it next time. Thanks for applying the patch. Regards, Michal > > I manually fixed both errors and applied it. > > Cheers, > Edgar > > > >> --- >> hw/serial.c | 1 + >> 1 files changed, 1 insertions(+), 0 deletions(-) >> >> diff --git a/hw/serial.c b/hw/serial.c >> index 49431b2..bf74876 100644 >> --- a/hw/serial.c >> +++ b/hw/serial.c >> @@ -674,6 +674,7 @@ static int serial_post_load(void *opaque, int version_id) >> } >> /* Initialize fcr via setter to perform essential side-effects */ >> serial_ioport_write(s, 0x02, s->fcr_vmstate); >> + serial_update_parameters(s); >> return 0; >> } >> >> -- >> 1.7.2.3 >> -- Michal Novotny, RHCE Virtualization Team (xen userspace), Red Hat