From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from [140.186.70.92] (port=37619 helo=eggs.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1OvuAw-00081g-TQ
	for qemu-devel@nongnu.org; Wed, 15 Sep 2010 11:45:40 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.69)
	(envelope-from <paolo.bonzini@gmail.com>) id 1OvuAr-0000re-Nz
	for qemu-devel@nongnu.org; Wed, 15 Sep 2010 11:45:34 -0400
Received: from mail-qw0-f45.google.com ([209.85.216.45]:58937)
	by eggs.gnu.org with esmtp (Exim 4.69)
	(envelope-from <paolo.bonzini@gmail.com>) id 1OvuAr-0000rX-KY
	for qemu-devel@nongnu.org; Wed, 15 Sep 2010 11:45:29 -0400
Received: by qwk4 with SMTP id 4so274242qwk.4
	for <qemu-devel@nongnu.org>; Wed, 15 Sep 2010 08:45:29 -0700 (PDT)
Sender: Paolo Bonzini <paolo.bonzini@gmail.com>
Message-ID: <4C90EA14.7040801@redhat.com>
Date: Wed, 15 Sep 2010 17:45:24 +0200
From: Paolo Bonzini <pbonzini@redhat.com>
MIME-Version: 1.0
References: <1284553440-17985-1-git-send-email-Jes.Sorensen@redhat.com>
	<1284553440-17985-3-git-send-email-Jes.Sorensen@redhat.com>
In-Reply-To: <1284553440-17985-3-git-send-email-Jes.Sorensen@redhat.com>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
Subject: [Qemu-devel] Re: [PATCH 2/5] Support human unit formats in
	strtobytes, eg. 1.0G
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Jes.Sorensen@redhat.com
Cc: quintela@redhat.com, qemu-devel@nongnu.org, armbru@redhat.com

On 09/15/2010 02:23 PM, Jes.Sorensen@redhat.com wrote:
>       switch (*endptr++) {
>       case 'K':
>       case 'k':
>           value<<= 10;
>           break;
>       case 0:
> +        if (divider) {
> +            value = 0;
> +            break;
> +        }
>       case 'M':
>       case 'm':
>           value<<= 20;
> @@ -284,9 +306,12 @@ uint64_t strtobytes(const char *nptr, char **end)
>       default:
>           value = 0;
>       }
> +    if (divider)
> +        value /= divider;
>

This risks overflow if you do 1.00000000000000G or something similarly 
braindead.  Do we loathe floating point so much that you cannot use 
strtod, like

     endptr1 = nptr + strspn(s, "0123456789.");
     switch (*endptr1)
     {
     case 0: divider = 1; break;
     case 'm': divider = 1 << 20; break;
     ...
     default: /* error, including for 1.0e+5 and negative */
     }
     value = (uint64_t) (strtod(nptr, &endptr2) / divider);
     if (endptr1 != endptr2) /* error, e.g. 1.2.3 */

     return value;

Paolo