From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from [140.186.70.92] (port=59839 helo=eggs.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1OvuGC-0003E8-J4
	for qemu-devel@nongnu.org; Wed, 15 Sep 2010 11:51:02 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.69)
	(envelope-from <anthony@codemonkey.ws>) id 1OvuG9-0001q8-J4
	for qemu-devel@nongnu.org; Wed, 15 Sep 2010 11:51:00 -0400
Received: from mail-vw0-f45.google.com ([209.85.212.45]:32858)
	by eggs.gnu.org with esmtp (Exim 4.69)
	(envelope-from <anthony@codemonkey.ws>) id 1OvuG9-0001pv-DG
	for qemu-devel@nongnu.org; Wed, 15 Sep 2010 11:50:57 -0400
Received: by vws19 with SMTP id 19so208932vws.4
	for <qemu-devel@nongnu.org>; Wed, 15 Sep 2010 08:50:56 -0700 (PDT)
Message-ID: <4C90EB5A.70903@codemonkey.ws>
Date: Wed, 15 Sep 2010 10:50:50 -0500
From: Anthony Liguori <anthony@codemonkey.ws>
MIME-Version: 1.0
Subject: Re: [Qemu-devel] Re: [PATCH 2/5] Support human unit formats in
	strtobytes, eg. 1.0G
References: <1284553440-17985-1-git-send-email-Jes.Sorensen@redhat.com>	<1284553440-17985-3-git-send-email-Jes.Sorensen@redhat.com>
	<4C90EA14.7040801@redhat.com>
In-Reply-To: <4C90EA14.7040801@redhat.com>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Paolo Bonzini <pbonzini@redhat.com>
Cc: Jes.Sorensen@redhat.com, qemu-devel@nongnu.org, armbru@redhat.com, quintela@redhat.com

On 09/15/2010 10:45 AM, Paolo Bonzini wrote:
> On 09/15/2010 02:23 PM, Jes.Sorensen@redhat.com wrote:
>>       switch (*endptr++) {
>>       case 'K':
>>       case 'k':
>>           value<<= 10;
>>           break;
>>       case 0:
>> +        if (divider) {
>> +            value = 0;
>> +            break;
>> +        }
>>       case 'M':
>>       case 'm':
>>           value<<= 20;
>> @@ -284,9 +306,12 @@ uint64_t strtobytes(const char *nptr, char **end)
>>       default:
>>           value = 0;
>>       }
>> +    if (divider)
>> +        value /= divider;
>>
>
> This risks overflow if you do 1.00000000000000G or something similarly 
> braindead.  Do we loathe floating point so much that you cannot use 
> strtod, like

It should be strtod.  Only badness can happen otherwise.

Regards,

Anthony Liguori

>     endptr1 = nptr + strspn(s, "0123456789.");
>     switch (*endptr1)
>     {
>     case 0: divider = 1; break;
>     case 'm': divider = 1 << 20; break;
>     ...
>     default: /* error, including for 1.0e+5 and negative */
>     }
>     value = (uint64_t) (strtod(nptr, &endptr2) / divider);
>     if (endptr1 != endptr2) /* error, e.g. 1.2.3 */
>
>     return value;
> Paolo
>