From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from [140.186.70.92] (port=36196 helo=eggs.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1OwFH4-0007Xt-3X
	for qemu-devel@nongnu.org; Thu, 16 Sep 2010 10:17:23 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.69)
	(envelope-from <agraf@suse.de>) id 1OwFGy-0000sw-HA
	for qemu-devel@nongnu.org; Thu, 16 Sep 2010 10:17:18 -0400
Received: from cantor2.suse.de ([195.135.220.15]:43171 helo=mx2.suse.de)
	by eggs.gnu.org with esmtp (Exim 4.69)
	(envelope-from <agraf@suse.de>) id 1OwFGy-0000se-9M
	for qemu-devel@nongnu.org; Thu, 16 Sep 2010 10:17:12 -0400
Message-ID: <4C9226E5.4080906@suse.de>
Date: Thu, 16 Sep 2010 16:17:09 +0200
From: Alexander Graf <agraf@suse.de>
MIME-Version: 1.0
References: <1284479530-4748-1-git-send-email-joerg.roedel@amd.com>
	<1284479530-4748-4-git-send-email-joerg.roedel@amd.com>
	<4C922478.7010703@redhat.com> <20100916141259.GA7972@amd.com>
In-Reply-To: <20100916141259.GA7972@amd.com>
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 7bit
Subject: [Qemu-devel] Re: [PATCH 3/3] Add svm cpuid features
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: "Roedel, Joerg" <Joerg.Roedel@amd.com>
Cc: Marcelo Tosatti <mtosatti@redhat.com>, Avi Kivity <avi@redhat.com>, "kvm@vger.kernel.org" <kvm@vger.kernel.org>, "qemu-devel@nongnu.org" <qemu-devel@nongnu.org>

Roedel, Joerg wrote:
> On Thu, Sep 16, 2010 at 10:06:48AM -0400, Avi Kivity wrote:
>   
>>   On 09/14/2010 05:52 PM, Joerg Roedel wrote:
>>     
>>> This patch adds the svm cpuid feature flags to the qemu
>>> intialization path. It also adds the svm features available
>>> on phenom to its cpu-definition and extends the host cpu
>>> type to support all svm features KVM can provide.
>>>
>>>
>>>       
>> Does phenom really have vmcbclean?  I thought it was a really new feature.
>>     
>
> No, but we could emulate it on almost all hardware that has SVM. Its
> basically the same as with x2apic.
>   

-cpu <non-host> is not about what we could emulate, but what the
hardware really is. Features not supported by the particular CPU do not
belong there.


Alex