From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from [140.186.70.92] (port=44054 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1OweaU-0002ud-Ut for qemu-devel@nongnu.org; Fri, 17 Sep 2010 13:19:03 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.69) (envelope-from ) id 1OweaT-0002br-Pl for qemu-devel@nongnu.org; Fri, 17 Sep 2010 13:19:02 -0400 Received: from mx1.redhat.com ([209.132.183.28]:49990) by eggs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1OweaT-0002bg-Iy for qemu-devel@nongnu.org; Fri, 17 Sep 2010 13:19:01 -0400 Message-ID: <4C93A319.5000900@redhat.com> Date: Fri, 17 Sep 2010 19:19:21 +0200 From: Kevin Wolf MIME-Version: 1.0 Subject: Re: [Qemu-devel] [PATCH 2/4] qcow2: Move sync out of update_refcount References: <1284740318-20838-1-git-send-email-kwolf@redhat.com> <1284740318-20838-3-git-send-email-kwolf@redhat.com> <4C93A01F.40706@codemonkey.ws> In-Reply-To: <4C93A01F.40706@codemonkey.ws> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Anthony Liguori Cc: qemu-devel@nongnu.org Am 17.09.2010 19:06, schrieb Anthony Liguori: > On 09/17/2010 11:18 AM, Kevin Wolf wrote: >> Note that the flush is omitted intentionally in qcow2_free_clusters. If >> anything, we can leak clusters here if we lose the writes. >> >> Signed-off-by: Kevin Wolf >> > > Cluster leaking gets picked up by bdrv_check though, right? > > I think I've convinced myself that leaking clusters is not an acceptable > behavior from a security perspective but as long as it's detectable via > bdrv_check, qcow2 could implement an online check to address it. Leaking clusters on crashes is unavoidable. But yes, qemu-img check does detect this. Kevin