qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Stefan Weil <weil@mail.berlios.de>
To: Blue Swirl <blauwirbel@gmail.com>
Cc: rr@bttr-software.de, "C.W. Betts" <computers57@hotmail.com>,
	qemu-devel <qemu-devel@nongnu.org>
Subject: Re: [Qemu-devel] [PATCH] mingw: add version information to the executables
Date: Sun, 19 Sep 2010 22:05:15 +0200	[thread overview]
Message-ID: <4C966CFB.5060108@mail.berlios.de> (raw)
In-Reply-To: <AANLkTikDqU5h+h_N57RHD0Sa_avn04jJ1OQo95_wMUSj@mail.gmail.com>

Could it be that the patch lines were wrapped by your mailer?
I cannot apply it here.

Regards, Stefan

Am 19.09.2010 10:42, schrieb Blue Swirl:
> Add QEMU version information to the executables, based on earlier
> work by C. W. Betts and Robert Riebisch.
>
> Signed-off-by: Blue Swirl<blauwirbel@gmail.com>
> ---
>   Makefile      |   10 +++++++---
>   Makefile.objs |    1 +
>   configure     |   12 ++++++++++++
>   version.rc    |   28 ++++++++++++++++++++++++++++
>   4 files changed, 48 insertions(+), 3 deletions(-)
>   create mode 100644 version.rc
>
> diff --git a/Makefile b/Makefile
> index ab91d42..732858b 100644
> --- a/Makefile
> +++ b/Makefile
> @@ -114,16 +114,20 @@ trace.o: trace.c $(GENERATED_HEADERS)
>
>   simpletrace.o: simpletrace.c $(GENERATED_HEADERS)
>
> +version.o: $(SRC_PATH)/version.rc config-host.mak
> +	$(call quiet-command,$(WINDRES) -I. -o $@ $<,"  RC    $(TARGET_DIR)$@")
> +
> +version-obj-$(CONFIG_WIN32) += version.o
>   ######################################################################
>
>   qemu-img.o: qemu-img-cmds.h
>   qemu-img.o qemu-tool.o qemu-nbd.o qemu-io.o: $(GENERATED_HEADERS)
>
> -qemu-img$(EXESUF): qemu-img.o qemu-tool.o qemu-error.o $(trace-obj-y)
> $(block-obj-y) $(qobject-obj-y)
>    

Line wrapped? git complains. More lines like this follow.

> +qemu-img$(EXESUF): qemu-img.o qemu-tool.o qemu-error.o $(trace-obj-y)
> $(block-obj-y) $(qobject-obj-y) $(version-obj-y)
>
> -qemu-nbd$(EXESUF): qemu-nbd.o qemu-tool.o qemu-error.o $(trace-obj-y)
> $(block-obj-y) $(qobject-obj-y)
> +qemu-nbd$(EXESUF): qemu-nbd.o qemu-tool.o qemu-error.o $(trace-obj-y)
> $(block-obj-y) $(qobject-obj-y) $(version-obj-y)
>
> -qemu-io$(EXESUF): qemu-io.o cmd.o qemu-tool.o qemu-error.o
> $(trace-obj-y) $(block-obj-y) $(qobject-obj-y)
> +qemu-io$(EXESUF): qemu-io.o cmd.o qemu-tool.o qemu-error.o
> $(trace-obj-y) $(block-obj-y) $(qobject-obj-y) $(version-obj-y)
>    
[snip]

      reply	other threads:[~2010-09-19 20:05 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-09-19  8:42 [Qemu-devel] [PATCH] mingw: add version information to the executables Blue Swirl
2010-09-19 20:05 ` Stefan Weil [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4C966CFB.5060108@mail.berlios.de \
    --to=weil@mail.berlios.de \
    --cc=blauwirbel@gmail.com \
    --cc=computers57@hotmail.com \
    --cc=qemu-devel@nongnu.org \
    --cc=rr@bttr-software.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).