From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from [140.186.70.92] (port=56114 helo=eggs.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1Oxc4t-0003uS-1u
	for qemu-devel@nongnu.org; Mon, 20 Sep 2010 04:50:24 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.69)
	(envelope-from <kwolf@redhat.com>) id 1Oxc4r-0002R2-SL
	for qemu-devel@nongnu.org; Mon, 20 Sep 2010 04:50:22 -0400
Received: from mx1.redhat.com ([209.132.183.28]:63423)
	by eggs.gnu.org with esmtp (Exim 4.69)
	(envelope-from <kwolf@redhat.com>) id 1Oxc4r-0002Qx-Hw
	for qemu-devel@nongnu.org; Mon, 20 Sep 2010 04:50:21 -0400
Message-ID: <4C972060.7030002@redhat.com>
Date: Mon, 20 Sep 2010 10:50:40 +0200
From: Kevin Wolf <kwolf@redhat.com>
MIME-Version: 1.0
Subject: Re: [Qemu-devel] [PATCH] e1000: Pad short frames to minimum size
	(60	bytes)
References: <1284842625-13920-1-git-send-email-stefanha@linux.vnet.ibm.com>	<20100918212710.GB3981@laped.lan>
	<AANLkTi=AM+o53WqPyjTycA+Xtqv+E1zRW2bUBAnc=Oqe@mail.gmail.com>
In-Reply-To: <AANLkTi=AM+o53WqPyjTycA+Xtqv+E1zRW2bUBAnc=Oqe@mail.gmail.com>
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 7bit
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Stefan Hajnoczi <stefanha@gmail.com>
Cc: qemu-devel@nongnu.org, "Edgar E. Iglesias" <edgar.iglesias@gmail.com>, 638955@bugs.launchpad.net, Stefan Hajnoczi <stefanha@linux.vnet.ibm.com>, "Michael S. Tsirkin" <mst@redhat.com>

Am 19.09.2010 08:36, schrieb Stefan Hajnoczi:
> On Sat, Sep 18, 2010 at 10:27 PM, Edgar E. Iglesias
> <edgar.iglesias@gmail.com> wrote:
>> This doesn't look right. AFAIK, MAC's dont pad on receive.
> 
> I agree.  NICs that do padding will do it on transmit, not receive.
> Anything coming in on the wire should already have the minimum length.
> 
> In QEMU that isn't true today and that's why rtl8139, pcnet, and
> ne2000 already do this same padding.  This patch is the smallest
> change to cover e1000.

What's the reason that it isn't true in QEMU today? Shouldn't we fix
these problems rather than making device emulations incorrect to
compensate for it?

Kevin