From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from [140.186.70.92] (port=60282 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1OxcnK-0005uT-Q5 for qemu-devel@nongnu.org; Mon, 20 Sep 2010 05:36:23 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.69) (envelope-from ) id 1OxcnI-0001yE-HK for qemu-devel@nongnu.org; Mon, 20 Sep 2010 05:36:18 -0400 Received: from mx1.redhat.com ([209.132.183.28]:22969) by eggs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1OxcnI-0001xu-5l for qemu-devel@nongnu.org; Mon, 20 Sep 2010 05:36:16 -0400 Received: from int-mx08.intmail.prod.int.phx2.redhat.com (int-mx08.intmail.prod.int.phx2.redhat.com [10.5.11.21]) by mx1.redhat.com (8.13.8/8.13.8) with ESMTP id o8K9aDeJ003361 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Mon, 20 Sep 2010 05:36:14 -0400 Received: from mig-laptop.brq.redhat.com (mig-laptop.brq.redhat.com [10.34.26.9]) by int-mx08.intmail.prod.int.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id o8K9aCSM001127 for ; Mon, 20 Sep 2010 05:36:13 -0400 Message-ID: <4C972B3A.7000800@redhat.com> Date: Mon, 20 Sep 2010 11:36:58 +0200 From: Michal Novotny MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="------------090403050606040409030402" Subject: [Qemu-devel] [PATCH] Fix vhost_net compilation errors for i386-softmmu target List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: "qemu-devel@nongnu.org" This is a multi-part message in MIME format. --------------090403050606040409030402 Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: quoted-printable X-MIME-Autoconverted: from 8bit to quoted-printable by mx1.redhat.com id o8K9aDeJ003361 Hi, there were compilation errors when I was trying to compile i386-softmmu=20 target on i386 host (running on Fedora-13 with development version of qemu downloaded=20 from git). There were errors of comparison of unsigned expression was always true=20 which made it unable to compile. This simple fix fixes the issue. ... cc1: warnings being treated as errors .../hw/vhost_net.c: In function =91vhost_net_start=92: .../vhost_net.c:154: error: comparison of unsigned expression >=3D 0 is=20 always true make[1]: *** [vhost_net.o] Error 1 make: *** [subdir-i386-softmmu] Error 2 Signed-off-by: Michal Novotny --=20 Michal Novotny, RHCE Virtualization Team (xen userspace), Red Hat --------------090403050606040409030402 Content-Type: text/x-patch; name="qemu-fix-vhost_net-compilation-errors.patch" Content-Disposition: attachment; filename="qemu-fix-vhost_net-compilation-errors.patch" Content-Transfer-Encoding: quoted-printable X-MIME-Autoconverted: from 8bit to quoted-printable by mx1.redhat.com id o8K9aDeJ003361 >>From 21dd405dbc871c8d0053cc68f8862665dc12f69a Mon Sep 17 00:00:00 2001 From: Michal Novotny Date: Mon, 20 Sep 2010 11:29:42 +0200 Subject: [PATCH] Fix vhost_net compilation errors for i386-softmmu target MIME-Version: 1.0 Content-Type: text/plain; charset=3DUTF-8 Content-Transfer-Encoding: 8bit Hi, there were compilation errors when I was trying to compile i386-softmmu t= arget on i386 host (running on Fedora-13 with development version of qemu downloaded fr= om git). There were errors of comparison of unsigned expression was always true wh= ich made it unable to compile. This simple fix fixes the issue. ... cc1: warnings being treated as errors .../hw/vhost_net.c: In function =E2=80=98vhost_net_start=E2=80=99: .../vhost_net.c:154: error: comparison of unsigned expression >=3D 0 is a= lways true make[1]: *** [vhost_net.o] Error 1 make: *** [subdir-i386-softmmu] Error 2 Signed-off-by: Michal Novotny --- hw/vhost_net.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/hw/vhost_net.c b/hw/vhost_net.c index 4a7b819..6958712 100644 --- a/hw/vhost_net.c +++ b/hw/vhost_net.c @@ -151,7 +151,7 @@ int vhost_net_start(struct vhost_net *net, return 0; fail: file.fd =3D -1; - while (--file.index >=3D 0) { + while (--file.index > 0) { int r =3D ioctl(net->dev.control, VHOST_NET_SET_BACKEND, &file); assert(r >=3D 0); } --=20 1.7.2.3 --------------090403050606040409030402--