From: Paolo Bonzini <pbonzini@redhat.com>
To: "Michael S. Tsirkin" <mst@redhat.com>
Cc: "Hervé Poussineau" <hpoussin@reactos.org>, qemu-devel@nongnu.org
Subject: [Qemu-devel] Re: [PATCH v2] [slirp] Make ARP replies at least 64 bytes long
Date: Mon, 20 Sep 2010 14:21:10 +0200 [thread overview]
Message-ID: <4C9751B6.8070008@redhat.com> (raw)
In-Reply-To: <20100920114313.GA24864@redhat.com>
On 09/20/2010 01:43 PM, Michael S. Tsirkin wrote:
> On Wed, Sep 15, 2010 at 10:33:26PM +0200, Hervé Poussineau wrote:
>> IEEE 802.3 standard requires Ethernet frames to be at least 64 bytes long.
>> If it is not the case, they will be considered as runt frames, and may be ignored by netcard and/or OS
>>
>> Signed-off-by: Hervé Poussineau<hpoussin@reactos.org>
>
> IMO slirp is not the best place for this, e.g. virtio-net
> does not need the padding.
I don't think it matters if virtio-net needs it or net; slirp should
comply to RFC and standards, so it should make frames the correct size.
Paolo
prev parent reply other threads:[~2010-09-20 12:21 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-09-15 20:33 [Qemu-devel] [PATCH v2] [slirp] Make ARP replies at least 64 bytes long Hervé Poussineau
2010-09-17 10:56 ` Edgar E. Iglesias
2010-09-20 11:43 ` [Qemu-devel] " Michael S. Tsirkin
2010-09-20 12:21 ` Paolo Bonzini [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4C9751B6.8070008@redhat.com \
--to=pbonzini@redhat.com \
--cc=hpoussin@reactos.org \
--cc=mst@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).