From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from [140.186.70.92] (port=43277 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1OxfMz-0002Xp-HA for qemu-devel@nongnu.org; Mon, 20 Sep 2010 08:21:18 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.69) (envelope-from ) id 1OxfMy-0004uS-4t for qemu-devel@nongnu.org; Mon, 20 Sep 2010 08:21:17 -0400 Received: from mail-pv0-f173.google.com ([74.125.83.173]:54122) by eggs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1OxfMy-0004uI-04 for qemu-devel@nongnu.org; Mon, 20 Sep 2010 08:21:16 -0400 Received: by pvh11 with SMTP id 11so1241135pvh.4 for ; Mon, 20 Sep 2010 05:21:14 -0700 (PDT) Sender: Paolo Bonzini Message-ID: <4C9751B6.8070008@redhat.com> Date: Mon, 20 Sep 2010 14:21:10 +0200 From: Paolo Bonzini MIME-Version: 1.0 References: <1284582806-4129-1-git-send-email-hpoussin@reactos.org> <20100920114313.GA24864@redhat.com> In-Reply-To: <20100920114313.GA24864@redhat.com> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 8bit Subject: [Qemu-devel] Re: [PATCH v2] [slirp] Make ARP replies at least 64 bytes long List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: "Michael S. Tsirkin" Cc: =?ISO-8859-1?Q?Herv=E9_Poussineau?= , qemu-devel@nongnu.org On 09/20/2010 01:43 PM, Michael S. Tsirkin wrote: > On Wed, Sep 15, 2010 at 10:33:26PM +0200, Hervé Poussineau wrote: >> IEEE 802.3 standard requires Ethernet frames to be at least 64 bytes long. >> If it is not the case, they will be considered as runt frames, and may be ignored by netcard and/or OS >> >> Signed-off-by: Hervé Poussineau > > IMO slirp is not the best place for this, e.g. virtio-net > does not need the padding. I don't think it matters if virtio-net needs it or net; slirp should comply to RFC and standards, so it should make frames the correct size. Paolo