From: Anthony Liguori <anthony@codemonkey.ws>
To: Michal Novotny <minovotn@redhat.com>
Cc: Paolo Bonzini <pbonzini@redhat.com>, qemu-devel <qemu-devel@nongnu.org>
Subject: Re: [Qemu-devel] Re: [PATCH] Make NIC model fallback to default when specified model is not supported
Date: Mon, 20 Sep 2010 09:35:14 -0500 [thread overview]
Message-ID: <4C977122.6010107@codemonkey.ws> (raw)
In-Reply-To: <4C974240.4070208@redhat.com>
On 09/20/2010 06:15 AM, Michal Novotny wrote:
> Well, this way I guess we should have 2, maybe 3 different approaches
> - different for qemu itself and for upstream version Xen using the
> older version of qemu-dm and RHEL-5 version.
>
> Therefore I think we should drop the patch for qemu (the one sent to
> this list) and decide about the others using their own lists/discussions.
BTW, the simple way to fix this in Xen is to launch qemu-dm -net
nic,model=?, parse the output to determine if the requested nic is
valid, then if it's not valid, print your warning to the user and then
select a "default" nic.
No need to implement this logic in qemu-dm itself.
Regards,
Anthony Liguori
> Michal
>
next prev parent reply other threads:[~2010-09-20 14:35 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-09-20 9:47 [Qemu-devel] [PATCH] Make NIC model fallback to default when specified model is not supported Michal Novotny
2010-09-20 10:34 ` [Qemu-devel] " Paolo Bonzini
2010-09-20 10:48 ` Michal Novotny
2010-09-20 10:53 ` Daniel P. Berrange
2010-09-20 11:05 ` Michal Novotny
2010-09-20 11:07 ` Daniel P. Berrange
2010-09-20 11:15 ` Michal Novotny
2010-09-20 14:35 ` Anthony Liguori [this message]
2010-09-20 17:58 ` Michael S. Tsirkin
2010-09-21 7:10 ` Michal Novotny
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4C977122.6010107@codemonkey.ws \
--to=anthony@codemonkey.ws \
--cc=minovotn@redhat.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).