From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from [140.186.70.92] (port=33754 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1OxmtK-0000sm-1q for qemu-devel@nongnu.org; Mon, 20 Sep 2010 16:23:11 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.69) (envelope-from ) id 1Oxms8-0006sv-KH for qemu-devel@nongnu.org; Mon, 20 Sep 2010 16:22:00 -0400 Received: from mail-pz0-f45.google.com ([209.85.210.45]:46933) by eggs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1Oxms8-0006sq-EQ for qemu-devel@nongnu.org; Mon, 20 Sep 2010 16:21:56 -0400 Received: by pzk12 with SMTP id 12so1416901pzk.4 for ; Mon, 20 Sep 2010 13:21:55 -0700 (PDT) Message-ID: <4C97C255.2020106@codemonkey.ws> Date: Mon, 20 Sep 2010 15:21:41 -0500 From: Anthony Liguori MIME-Version: 1.0 Subject: Re: [Qemu-devel] Win2k host problem with {get,free}{addr,name}info() References: <4C911D8F.1060406@codemonkey.ws> <4C97A73C.4070102@codemonkey.ws> In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Blue Swirl Cc: qemu-devel On 09/20/2010 03:03 PM, Blue Swirl wrote: > On Mon, Sep 20, 2010 at 6:41 PM, Blue Swirl wrote: > >> On Mon, Sep 20, 2010 at 6:26 PM, Anthony Liguori wrote: >> >>> On 09/19/2010 11:16 AM, Blue Swirl wrote: >>> >>>> On Wed, Sep 15, 2010 at 7:25 PM, Anthony Liguori >>>> wrote: >>>> >>>> >>>>> On 09/15/2010 02:11 PM, Blue Swirl wrote: >>>>> >>>>> >>>>>> Hi, >>>>>> >>>>>> I tried to test QEMU on Win2k, but there are run time errors because >>>>>> of missing {get,free}{addr,name}info() functions. After adding dummy >>>>>> defines in place, there are no more errors. >>>>>> >>>>>> I found a similar case, where a compatibility patch was proposed: >>>>>> http://trac.filezilla-project.org/ticket/1532 >>>>>> >>>>>> The patch is a bit heavy, consisting of run time detection of Win2k >>>>>> and full replacements for the functions. Are there any alternative >>>>>> solutions? I'm by no means a Windows expert. >>>>>> >>>>>> >>>>>> >>>>> Win2k is EOL so I don't think it's useful for us to support it as a host. >>>>> So any type of patch is just going to add additional complexity for very >>>>> little real gain. >>>>> >>>>> >>>> I made a compatibility patch based on the FileZilla patch. The impact >>>> is very low, outside of the new files added, only Makefiles are >>>> changed. >>>> >>>> >>> Does gnulib have a similar replacement function? >>> >> Very similar, in fact that must be the source. >> >> >>> The nice thing about gnulib is that in the long term, we could potentially >>> use gnulib for compatibility and make sure to get updated code. >>> >> One problem is that the current versions use GPLv3. >> > Sorry, I made too hasty conclusions based on a few files. > getaddrinfo.c and inet_ntop.c are both GPLv2+. > Perfect, that works out very well then. Regards, Anthony Liguori