From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from [140.186.70.92] (port=41545 helo=eggs.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1OxwsO-0000Db-GE
	for qemu-devel@nongnu.org; Tue, 21 Sep 2010 03:02:54 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.69)
	(envelope-from <minovotn@redhat.com>) id 1OxwsI-0006af-5F
	for qemu-devel@nongnu.org; Tue, 21 Sep 2010 03:02:47 -0400
Received: from mx1.redhat.com ([209.132.183.28]:47144)
	by eggs.gnu.org with esmtp (Exim 4.69)
	(envelope-from <minovotn@redhat.com>) id 1OxwsH-0006aJ-Uj
	for qemu-devel@nongnu.org; Tue, 21 Sep 2010 03:02:46 -0400
Received: from int-mx01.intmail.prod.int.phx2.redhat.com
	(int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11])
	by mx1.redhat.com (8.13.8/8.13.8) with ESMTP id o8L72iO8003298
	(version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK)
	for <qemu-devel@nongnu.org>; Tue, 21 Sep 2010 03:02:44 -0400
Message-ID: <4C9858B4.4090305@redhat.com>
Date: Tue, 21 Sep 2010 09:03:16 +0200
From: Michal Novotny <minovotn@redhat.com>
MIME-Version: 1.0
References: <4C972B3A.7000800@redhat.com> <20100920175328.GC30611@redhat.com>
In-Reply-To: <20100920175328.GC30611@redhat.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: quoted-printable
Subject: [Qemu-devel] Re: [PATCH] Fix vhost_net compilation errors for
	i386-softmmu target
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: "Michael S. Tsirkin" <mst@redhat.com>
Cc: "qemu-devel@nongnu.org" <qemu-devel@nongnu.org>

On 09/20/2010 07:53 PM, Michael S. Tsirkin wrote:
> On Mon, Sep 20, 2010 at 11:36:58AM +0200, Michal Novotny wrote:
>   =20
>> Hi,
>> there were compilation errors when I was trying to compile
>> i386-softmmu target on i386
>> host (running on Fedora-13 with development version of qemu
>> downloaded from git).
>>
>> There were errors of comparison of unsigned expression was always
>> true which made it
>> unable to compile. This simple fix fixes the issue.
>>
>> ...
>> cc1: warnings being treated as errors
>> .../hw/vhost_net.c: In function =E2=80=98vhost_net_start=E2=80=99:
>> .../vhost_net.c:154: error: comparison of unsigned expression>=3D 0
>> is always true
>> make[1]: *** [vhost_net.o] Error 1
>> make: *** [subdir-i386-softmmu] Error 2
>>
>> Signed-off-by: Michal Novotny<minovotn@redhat.com>
>>
>> --=20
>> Michal Novotny<minovotn@redhat.com>, RHCE
>> Virtualization Team (xen userspace), Red Hat
>>
>>     =20
> This is not the right fix though. I have queued
> the correct one on my tree, will send pull request.
>
>   =20

Oh, ok. Nevertheless according to the definition of file.index to be=20
unsigned it can never be negative value so that's why I implemented the=20
check against greater than zero rather than equal or greater than zero=20
but maybe that's not the right way to fix it like you say. However,=20
since your patch is already in the queue as you told me it's fine.

Michal

--=20
Michal Novotny<minovotn@redhat.com>, RHCE
Virtualization Team (xen userspace), Red Hat