From: Kevin Wolf <kwolf@redhat.com>
To: Christoph Hellwig <hch@lst.de>
Cc: qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH 5/5] ide: propagate the required alignment
Date: Tue, 21 Sep 2010 12:59:23 +0200 [thread overview]
Message-ID: <4C98900B.8070405@redhat.com> (raw)
In-Reply-To: <20100912214400.GD4893@lst.de>
Am 12.09.2010 23:44, schrieb Christoph Hellwig:
> IDE is a bit ugly in this respect. For one it doesn't really keep track
> of a sector size - most of the protocol is in units of 512 bytes, and we
> assume 2048 bytes for CDROMs which is correct most of the time.
>
> Second IDE allocates an I/O buffer long before we know if we're dealing
> with a CDROM or not, so increase the alignment for the io_buffer
> unconditionally.
>
> Signed-off-by: Christoph Hellwig <hch@lst.de>
I'm not very happy about the last three patches in this series because
they mix guest device and backend properties. But it's probably the best
we can get without major effort.
Applied all to the block branch.
Kevin
next prev parent reply other threads:[~2010-09-21 10:59 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-09-12 21:42 [Qemu-devel] [PATCH 1/5] use qemu_blockalign consistently Christoph Hellwig
2010-09-12 21:43 ` [Qemu-devel] [PATCH 2/5] raw-posix: handle > 512 byte alignment correctly Christoph Hellwig
2010-09-12 21:43 ` [Qemu-devel] [PATCH 3/5] virtio-blk: propagate the required alignment Christoph Hellwig
2010-09-12 21:43 ` [Qemu-devel] [PATCH 4/5] scsi-disk: " Christoph Hellwig
2010-09-12 21:44 ` [Qemu-devel] [PATCH 5/5] ide: " Christoph Hellwig
2010-09-21 10:59 ` Kevin Wolf [this message]
2010-09-13 19:02 ` [Qemu-devel] [PATCH 1/5] use qemu_blockalign consistently Stefan Hajnoczi
2010-09-14 16:09 ` Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4C98900B.8070405@redhat.com \
--to=kwolf@redhat.com \
--cc=hch@lst.de \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).