From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from [140.186.70.92] (port=53096 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1Oy0Z5-0001Jw-AX for qemu-devel@nongnu.org; Tue, 21 Sep 2010 06:59:16 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.69) (envelope-from ) id 1Oy0Yw-0005BG-6r for qemu-devel@nongnu.org; Tue, 21 Sep 2010 06:59:11 -0400 Received: from mx1.redhat.com ([209.132.183.28]:40549) by eggs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1Oy0Yv-0005Ax-QI for qemu-devel@nongnu.org; Tue, 21 Sep 2010 06:59:02 -0400 Message-ID: <4C98900B.8070405@redhat.com> Date: Tue, 21 Sep 2010 12:59:23 +0200 From: Kevin Wolf MIME-Version: 1.0 Subject: Re: [Qemu-devel] [PATCH 5/5] ide: propagate the required alignment References: <20100912214256.GA4854@lst.de> <20100912214400.GD4893@lst.de> In-Reply-To: <20100912214400.GD4893@lst.de> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Christoph Hellwig Cc: qemu-devel@nongnu.org Am 12.09.2010 23:44, schrieb Christoph Hellwig: > IDE is a bit ugly in this respect. For one it doesn't really keep track > of a sector size - most of the protocol is in units of 512 bytes, and we > assume 2048 bytes for CDROMs which is correct most of the time. > > Second IDE allocates an I/O buffer long before we know if we're dealing > with a CDROM or not, so increase the alignment for the io_buffer > unconditionally. > > Signed-off-by: Christoph Hellwig I'm not very happy about the last three patches in this series because they mix guest device and backend properties. But it's probably the best we can get without major effort. Applied all to the block branch. Kevin