From: Anthony Liguori <anthony@codemonkey.ws>
To: "Michael S. Tsirkin" <mst@redhat.com>
Cc: qemu-devel@nongnu.org
Subject: [Qemu-devel] Re: [PATCH] net: delay peer host device delete
Date: Tue, 21 Sep 2010 07:42:19 -0500 [thread overview]
Message-ID: <4C98A82B.2010703@codemonkey.ws> (raw)
In-Reply-To: <20100921091851.GC4365@redhat.com>
On 09/21/2010 04:18 AM, Michael S. Tsirkin wrote:
>> No, netdev_del should remove the VLANClientState from the
>> non_vlan_clients list.
>>
>> It's no longer enumerable and it's no longer lookup-able.
>>
>> The only reason it stays around it so that the device doesn't have a
>> reference to a free pointer. The only field that's ever looked at
>> is is_deleted which is used by every function to turn around and
>> implement a nop.
>>
>> The VLANClientState is a hollow shell of it's former glorious self.
>> The remainder of it's (hopefully short) life is merely so that we
>> can avoid touching every device to teach them about disconnecting
>> backends.
>>
> We'll have to tell them link is down, won't we?
>
Yes, that would be a nice touch.
Regards,
Anthony Liguori
prev parent reply other threads:[~2010-09-21 12:43 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-09-20 16:30 [Qemu-devel] [PATCH] net: delay peer host device delete Michael S. Tsirkin
2010-09-20 16:41 ` Anthony Liguori
2010-09-20 16:47 ` Michael S. Tsirkin
2010-09-20 16:56 ` Anthony Liguori
2010-09-20 17:14 ` Michael S. Tsirkin
2010-09-20 18:14 ` Anthony Liguori
2010-09-20 18:19 ` Anthony Liguori
2010-09-20 18:59 ` [Qemu-devel] " Michael S. Tsirkin
2010-09-20 19:22 ` Anthony Liguori
2010-09-20 19:37 ` Michael S. Tsirkin
2010-09-20 20:15 ` Anthony Liguori
2010-09-20 20:15 ` Michael S. Tsirkin
2010-09-21 8:58 ` Daniel P. Berrange
2010-09-21 9:20 ` Michael S. Tsirkin
2010-09-21 12:47 ` Anthony Liguori
2010-09-20 18:24 ` Michael S. Tsirkin
2010-09-20 18:39 ` Anthony Liguori
2010-09-20 19:15 ` Michael S. Tsirkin
2010-09-20 19:28 ` Anthony Liguori
2010-09-20 19:44 ` Michael S. Tsirkin
2010-09-20 20:20 ` Anthony Liguori
2010-09-20 20:27 ` Michael S. Tsirkin
2010-09-20 20:38 ` Anthony Liguori
2010-09-20 20:37 ` Michael S. Tsirkin
2010-09-20 20:50 ` Anthony Liguori
2010-09-21 9:18 ` Michael S. Tsirkin
2010-09-21 12:42 ` Anthony Liguori [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4C98A82B.2010703@codemonkey.ws \
--to=anthony@codemonkey.ws \
--cc=mst@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).