From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from [140.186.70.92] (port=43730 helo=eggs.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1Oysef-0003TA-K0
	for qemu-devel@nongnu.org; Thu, 23 Sep 2010 16:44:34 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.69)
	(envelope-from <weil@mail.berlios.de>) id 1Oysee-0003Wv-0c
	for qemu-devel@nongnu.org; Thu, 23 Sep 2010 16:44:33 -0400
Received: from moutng.kundenserver.de ([212.227.126.186]:58655)
	by eggs.gnu.org with esmtp (Exim 4.69)
	(envelope-from <weil@mail.berlios.de>) id 1Oysed-0003WZ-K1
	for qemu-devel@nongnu.org; Thu, 23 Sep 2010 16:44:31 -0400
Message-ID: <4C9BBC2B.2030004@mail.berlios.de>
Date: Thu, 23 Sep 2010 22:44:27 +0200
From: Stefan Weil <weil@mail.berlios.de>
MIME-Version: 1.0
References: <1285270085-11276-1-git-send-email-weil@mail.berlios.de>
	<1285270085-11276-2-git-send-email-weil@mail.berlios.de>
	<AANLkTik0zTpZagGwWFcHB55+veoP5mdHgvM4qg59n8f9@mail.gmail.com>
In-Reply-To: <AANLkTik0zTpZagGwWFcHB55+veoP5mdHgvM4qg59n8f9@mail.gmail.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Subject: [Qemu-devel] Re: [PATCH 2/3] Replace remaining gcc format attribute
 by macro GCC_FMT_ATTR (format checking)
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Blue Swirl <blauwirbel@gmail.com>
Cc: QEMU Developers <qemu-devel@nongnu.org>

Am 23.09.2010 22:33, schrieb Blue Swirl:
> On Thu, Sep 23, 2010 at 7:28 PM, Stefan Weil <weil@mail.berlios.de> wrote:
>> Replace the remaining format attribute printf by macro
>> GCC_FMT_ATTR which uses gnu_printf (if supported).
>>
>> This needs additional code changes:
>>
>> * Add qemu-common.h (which defined GCC_FMT_ATTR) were needed.
>>
>> * Remove standard includes when qemu-common.h was added.
>>  qemu-common.h already provides these includes.
>>
>> * Remove local definitions which now come from stdio.h.
>>  These definitions were needed before tcg was introduced.
>>  They raise conflicts when qemu-common.h is included.
>
> IIRC the problem was that some system headers were incompatible with
> global asm variables. There is still one, AREG0.
>
> But I'd rather not keep the hideous local definitions forever. Maybe
> those systems which are broken by the patch are not interesting
> anymore?

Are there such systems? Or did the problems with earlier
versions arise from the fact that a lot of global asm variables
were reserved by qemu? How could a correctly defined AREG0
interfere with system headers?

For linux and win32, I did not notice problems caused by these changes.