From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from [140.186.70.92] (port=42822 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1P0FA7-0005Ky-KU for qemu-devel@nongnu.org; Mon, 27 Sep 2010 10:58:41 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.69) (envelope-from ) id 1P0FA6-0001HC-3N for qemu-devel@nongnu.org; Mon, 27 Sep 2010 10:58:39 -0400 Received: from mx1.redhat.com ([209.132.183.28]:24140) by eggs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1P0FA5-0001Gt-TP for qemu-devel@nongnu.org; Mon, 27 Sep 2010 10:58:38 -0400 Message-ID: <4CA0B116.4070107@redhat.com> Date: Mon, 27 Sep 2010 16:58:30 +0200 From: Avi Kivity MIME-Version: 1.0 References: <1285593377-1754-1-git-send-email-joerg.roedel@amd.com> <1285593377-1754-4-git-send-email-joerg.roedel@amd.com> In-Reply-To: <1285593377-1754-4-git-send-email-joerg.roedel@amd.com> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Subject: [Qemu-devel] Re: [PATCH 3/3] Add svm cpuid features List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Joerg Roedel Cc: Marcelo Tosatti , Alexander Graf , kvm@vger.kernel.org, qemu-devel@nongnu.org On 09/27/2010 03:16 PM, Joerg Roedel wrote: > This patch adds the svm cpuid feature flags to the qemu > intialization path. It also adds the svm features available > on phenom to its cpu-definition and extends the host cpu > type to support all svm features KVM can provide. > This should really be "all svm features" since we'll later mask them with kvm capabilities. This way, if we later add more capabilities, we automatically gain support in userspace. (or rather, all svm features that don't need save/restore support in userspace; I don't think any do, beyond svm itself) -- error compiling committee.c: too many arguments to function