From: Avi Kivity <avi@redhat.com>
To: "Roedel, Joerg" <Joerg.Roedel@amd.com>
Cc: Marcelo Tosatti <mtosatti@redhat.com>,
Alexander Graf <agraf@suse.de>,
"kvm@vger.kernel.org" <kvm@vger.kernel.org>,
"qemu-devel@nongnu.org" <qemu-devel@nongnu.org>
Subject: [Qemu-devel] Re: [PATCH 3/3] Add svm cpuid features
Date: Mon, 27 Sep 2010 18:22:13 +0200 [thread overview]
Message-ID: <4CA0C4B5.2010303@redhat.com> (raw)
In-Reply-To: <20100927154049.GI9817@amd.com>
On 09/27/2010 05:40 PM, Roedel, Joerg wrote:
> On Mon, Sep 27, 2010 at 11:02:23AM -0400, Avi Kivity wrote:
> > On 09/27/2010 04:58 PM, Avi Kivity wrote:
> > > On 09/27/2010 03:16 PM, Joerg Roedel wrote:
> > >> This patch adds the svm cpuid feature flags to the qemu
> > >> intialization path. It also adds the svm features available
> > >> on phenom to its cpu-definition and extends the host cpu
> > >> type to support all svm features KVM can provide.
> > >>
> > >
> > > This should really be "all svm features" since we'll later mask them
> > > with kvm capabilities. This way, if we later add more capabilities,
> > > we automatically gain support in userspace.
>
> Yes, that is what -cpu host does with these patches applied. The
> svm_features variable is set to -1 in this case and masked out later
> with the KVM capabilities.
>
Well, running current uq/master I get:
has_svm: can't execute cpuid 0x8000000a
kvm: no hardware support
?
--
error compiling committee.c: too many arguments to function
next prev parent reply other threads:[~2010-09-27 16:22 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-09-27 13:16 [Qemu-devel] [PATCH 0/3] SVM feature support for qemu v3 Joerg Roedel
2010-09-27 13:16 ` [Qemu-devel] [PATCH 1/3] Make kvm64 the default cpu model when kvm_enabled() Joerg Roedel
2010-10-06 18:53 ` [Qemu-devel] " Marcelo Tosatti
2010-10-06 19:24 ` Anthony Liguori
2010-10-07 8:42 ` Roedel, Joerg
2010-10-07 12:48 ` Anthony Liguori
2010-10-18 8:22 ` Roedel, Joerg
2010-10-18 14:16 ` Anthony Liguori
2010-10-20 15:53 ` Blue Swirl
2010-09-27 13:16 ` [Qemu-devel] [PATCH 2/3] Set cpuid definition to 0 before initializing it Joerg Roedel
2010-09-27 13:16 ` [Qemu-devel] [PATCH 3/3] Add svm cpuid features Joerg Roedel
2010-09-27 14:58 ` [Qemu-devel] " Avi Kivity
2010-09-27 15:02 ` Avi Kivity
2010-09-27 15:40 ` Roedel, Joerg
2010-09-27 16:22 ` Avi Kivity [this message]
2010-09-28 9:28 ` Roedel, Joerg
2010-09-28 9:37 ` Avi Kivity
2010-09-28 10:05 ` Roedel, Joerg
2010-09-28 10:16 ` Avi Kivity
2010-10-06 18:57 ` Marcelo Tosatti
-- strict thread matches above, loose matches on Subject: below --
2010-09-14 15:52 [Qemu-devel] [PATCH 0/3] SVM feature support for qemu Joerg Roedel
2010-09-14 15:52 ` [Qemu-devel] [PATCH 3/3] Add svm cpuid features Joerg Roedel
2010-09-16 14:06 ` [Qemu-devel] " Avi Kivity
2010-09-16 14:12 ` Roedel, Joerg
2010-09-16 14:17 ` Alexander Graf
2010-09-16 14:26 ` Roedel, Joerg
2010-09-16 14:28 ` Alexander Graf
2010-09-16 14:35 ` Roedel, Joerg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4CA0C4B5.2010303@redhat.com \
--to=avi@redhat.com \
--cc=Joerg.Roedel@amd.com \
--cc=agraf@suse.de \
--cc=kvm@vger.kernel.org \
--cc=mtosatti@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).