From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from [140.186.70.92] (port=39008 helo=eggs.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1P0GT7-0004Vj-QV
	for qemu-devel@nongnu.org; Mon, 27 Sep 2010 12:22:22 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.69)
	(envelope-from <avi@redhat.com>) id 1P0GT6-0000nr-Ht
	for qemu-devel@nongnu.org; Mon, 27 Sep 2010 12:22:21 -0400
Received: from mx1.redhat.com ([209.132.183.28]:28327)
	by eggs.gnu.org with esmtp (Exim 4.69)
	(envelope-from <avi@redhat.com>) id 1P0GT6-0000nj-8F
	for qemu-devel@nongnu.org; Mon, 27 Sep 2010 12:22:20 -0400
Message-ID: <4CA0C4B5.2010303@redhat.com>
Date: Mon, 27 Sep 2010 18:22:13 +0200
From: Avi Kivity <avi@redhat.com>
MIME-Version: 1.0
References: <1285593377-1754-1-git-send-email-joerg.roedel@amd.com>
	<1285593377-1754-4-git-send-email-joerg.roedel@amd.com>
	<4CA0B116.4070107@redhat.com> <4CA0B1FF.8040903@redhat.com>
	<20100927154049.GI9817@amd.com>
In-Reply-To: <20100927154049.GI9817@amd.com>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
Subject: [Qemu-devel] Re: [PATCH 3/3] Add svm cpuid features
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: "Roedel, Joerg" <Joerg.Roedel@amd.com>
Cc: Marcelo Tosatti <mtosatti@redhat.com>, Alexander Graf <agraf@suse.de>, "kvm@vger.kernel.org" <kvm@vger.kernel.org>, "qemu-devel@nongnu.org" <qemu-devel@nongnu.org>

  On 09/27/2010 05:40 PM, Roedel, Joerg wrote:
> On Mon, Sep 27, 2010 at 11:02:23AM -0400, Avi Kivity wrote:
> >    On 09/27/2010 04:58 PM, Avi Kivity wrote:
> >  >   On 09/27/2010 03:16 PM, Joerg Roedel wrote:
> >  >>  This patch adds the svm cpuid feature flags to the qemu
> >  >>  intialization path. It also adds the svm features available
> >  >>  on phenom to its cpu-definition and extends the host cpu
> >  >>  type to support all svm features KVM can provide.
> >  >>
> >  >
> >  >  This should really be "all svm features" since we'll later mask them
> >  >  with kvm capabilities.  This way, if we later add more capabilities,
> >  >  we automatically gain support in userspace.
>
> Yes, that is what -cpu host does with these patches applied. The
> svm_features variable is set to -1 in this case and masked out later
> with the KVM capabilities.
>

Well, running current uq/master I get:

   has_svm: can't execute cpuid 0x8000000a
   kvm: no hardware support

?

-- 
error compiling committee.c: too many arguments to function