From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from [140.186.70.92] (port=57823 helo=eggs.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1P0rF8-0003kL-LH
	for qemu-devel@nongnu.org; Wed, 29 Sep 2010 03:38:27 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.69)
	(envelope-from <kraxel@redhat.com>) id 1P0rF3-0001CX-5n
	for qemu-devel@nongnu.org; Wed, 29 Sep 2010 03:38:22 -0400
Received: from mx1.redhat.com ([209.132.183.28]:54525)
	by eggs.gnu.org with esmtp (Exim 4.69)
	(envelope-from <kraxel@redhat.com>) id 1P0rF2-0001Bt-Vy
	for qemu-devel@nongnu.org; Wed, 29 Sep 2010 03:38:17 -0400
Message-ID: <4CA2ECDA.5080309@redhat.com>
Date: Wed, 29 Sep 2010 09:38:02 +0200
From: Gerd Hoffmann <kraxel@redhat.com>
MIME-Version: 1.0
Subject: Re: [Qemu-devel] Re: [PATCH RFC V4 10/14] Introduce
	qemu_ram_ptr_unlock.
References: <1285686097-13036-1-git-send-email-anthony.perard@citrix.com>	<1285686097-13036-11-git-send-email-anthony.perard@citrix.com>
	<4CA2064A.7020701@codemonkey.ws>
In-Reply-To: <4CA2064A.7020701@codemonkey.ws>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Anthony Liguori <anthony@codemonkey.ws>
Cc: anthony.perard@citrix.com, xen-devel@lists.xensource.com, qemu-devel@nongnu.org, Stefano.Stabellini@eu.citrix.com

On 09/28/10 17:14, Anthony Liguori wrote:
> On 09/28/2010 10:01 AM, anthony.perard@citrix.com wrote:
>> From: Anthony PERARD<anthony.perard@citrix.com>
>>
>> This function allows to unlock a ram_ptr give by qemu_get_ram_ptr. After
>> a call to qemu_ram_ptr_unlock, the pointer may be unmap from QEMU when
>> used with Xen.
>>
>> Signed-off-by: Anthony PERARD<anthony.perard@citrix.com>
>
> Why isn't hooking cpu_physical_memory_{map,unmap}() not enough? That's
> really the intention of the API.

I think quite a bunch of stuff stops working then because it doesn't 
properly use the map/unmap API ...

cheers,
   Gerd