qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Stefan Weil <weil@mail.berlios.de>
To: Blue Swirl <blauwirbel@gmail.com>
Cc: QEMU Developers <qemu-devel@nongnu.org>
Subject: [Qemu-devel] Re: [PATCH] ds1225y: Fix compiler errors in debug code
Date: Thu, 30 Sep 2010 21:55:54 +0200	[thread overview]
Message-ID: <4CA4EB4A.6010400@mail.berlios.de> (raw)
In-Reply-To: <AANLkTik5zH0-GUYMaW74OtSBZE0CsxwjTtSxpu045mHv@mail.gmail.com>

Am 30.09.2010 21:37, schrieb Blue Swirl:
> On Thu, Sep 30, 2010 at 7:30 PM, Stefan Weil<weil@mail.berlios.de>  wrote:
>    
>> TARGET_FMT_lx is not allowed here, so use type casts to unsigned
>> (which should be large enough to hold typical nvram addresses).
>>      
> The correct format is TARGET_FMT_plx.
>    


addr is typically less than 8192 (size of nvram).

TARGET_FMT_plx displays addr using 16 hex characters
when the target has 64 bit addresses. That's correct but
does not look pretty.

Do you prefer TARGET_FMT_plx nevertheless?

  reply	other threads:[~2010-09-30 19:56 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-09-30 19:30 [Qemu-devel] [PATCH] ds1225y: Fix compiler errors in debug code Stefan Weil
2010-09-30 19:37 ` [Qemu-devel] " Blue Swirl
2010-09-30 19:55   ` Stefan Weil [this message]
2010-09-30 20:09     ` Blue Swirl
2010-09-30 20:22       ` Stefan Weil

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4CA4EB4A.6010400@mail.berlios.de \
    --to=weil@mail.berlios.de \
    --cc=blauwirbel@gmail.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).