From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from [140.186.70.92] (port=55091 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1P1PEW-0001js-PI for qemu-devel@nongnu.org; Thu, 30 Sep 2010 15:56:01 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1P1PEV-0003Nk-Ax for qemu-devel@nongnu.org; Thu, 30 Sep 2010 15:56:00 -0400 Received: from moutng.kundenserver.de ([212.227.126.187]:60952) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1P1PEU-0003NW-W8 for qemu-devel@nongnu.org; Thu, 30 Sep 2010 15:55:59 -0400 Message-ID: <4CA4EB4A.6010400@mail.berlios.de> Date: Thu, 30 Sep 2010 21:55:54 +0200 From: Stefan Weil MIME-Version: 1.0 References: <1285875019-14246-1-git-send-email-weil@mail.berlios.de> In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Subject: [Qemu-devel] Re: [PATCH] ds1225y: Fix compiler errors in debug code List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Blue Swirl Cc: QEMU Developers Am 30.09.2010 21:37, schrieb Blue Swirl: > On Thu, Sep 30, 2010 at 7:30 PM, Stefan Weil wrote: > >> TARGET_FMT_lx is not allowed here, so use type casts to unsigned >> (which should be large enough to hold typical nvram addresses). >> > The correct format is TARGET_FMT_plx. > addr is typically less than 8192 (size of nvram). TARGET_FMT_plx displays addr using 16 hex characters when the target has 64 bit addresses. That's correct but does not look pretty. Do you prefer TARGET_FMT_plx nevertheless?