From: Stefan Weil <weil@mail.berlios.de>
To: "Edgar E. Iglesias" <edgar.iglesias@gmail.com>
Cc: Alexander Graf <agraf@suse.de>, qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH 0/2] powerpc: Add a virtex5 ml507 refdesign board (v2)
Date: Sat, 02 Oct 2010 13:02:50 +0200 [thread overview]
Message-ID: <4CA7115A.8060201@mail.berlios.de> (raw)
In-Reply-To: <20100930171226.GB10823@laped.lan>
Am 30.09.2010 19:12, schrieb Edgar E. Iglesias:
> On Thu, Sep 30, 2010 at 03:15:54PM +0200, Alexander Graf wrote:
>> Edgar E. Iglesias wrote:
>>> v2:
>>> * Address review comments from A. Graf.
>>>
>>> Edgar E. Iglesias (2):
>>> powerpc: Add a ppc-440x5 Xilinx model
>>> powerpc: Add a virtex5 ml507 refdesign board
>>>
>>> Makefile.target | 8 +
>>> default-configs/ppc-softmmu.mak | 2 +
>>> default-configs/ppc64-softmmu.mak | 2 +
>>> default-configs/ppcemb-softmmu.mak | 2 +
>>> hw/virtex_ml507.c | 278 ++++++++++++++++++++++++++++++++++++
>>> target-ppc/cpu.h | 4 +
>>> target-ppc/translate_init.c | 6 +-
>>> 7 files changed, 300 insertions(+), 2 deletions(-)
>>> create mode 100644 hw/virtex_ml507.c
>>>
>>>
>>>
>> No complaints from me. Feel free to apply them.
>>
>> Signed-off-by: Alexander Graf <agraf@suse.de>
>
> Applied, thanks.
>
> Cheers
>
>
What about coding conventions?
New source files should comply with CODING_STYLE (block structure).
virtex_ml507.c:
+ if (!fdt)
+ return 0;
Cheers,
next prev parent reply other threads:[~2010-10-02 11:02 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-09-29 13:40 [Qemu-devel] [PATCH 0/2] powerpc: Add a virtex5 ml507 refdesign board (v2) Edgar E. Iglesias
2010-09-29 13:40 ` [Qemu-devel] [PATCH 1/2] powerpc: Add a ppc-440x5 Xilinx model Edgar E. Iglesias
2010-09-29 13:40 ` [Qemu-devel] [PATCH 2/2] powerpc: Add a virtex5 ml507 refdesign board Edgar E. Iglesias
2010-09-30 13:15 ` [Qemu-devel] [PATCH 0/2] powerpc: Add a virtex5 ml507 refdesign board (v2) Alexander Graf
2010-09-30 17:12 ` Edgar E. Iglesias
2010-10-02 11:02 ` Stefan Weil [this message]
2010-10-02 11:07 ` Alexander Graf
2010-10-02 11:22 ` Edgar E. Iglesias
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4CA7115A.8060201@mail.berlios.de \
--to=weil@mail.berlios.de \
--cc=agraf@suse.de \
--cc=edgar.iglesias@gmail.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).