From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from [140.186.70.92] (port=34298 helo=eggs.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1P3l03-0002YC-H3
	for qemu-devel@nongnu.org; Thu, 07 Oct 2010 03:34:51 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <gceq-qemu-devel@m.gmane.org>) id 1P3kmW-0005QW-9Q
	for qemu-devel@nongnu.org; Thu, 07 Oct 2010 03:20:49 -0400
Received: from lo.gmane.org ([80.91.229.12]:53996)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <gceq-qemu-devel@m.gmane.org>) id 1P3kmW-0005QF-3y
	for qemu-devel@nongnu.org; Thu, 07 Oct 2010 03:20:48 -0400
Received: from list by lo.gmane.org with local (Exim 4.69)
	(envelope-from <gceq-qemu-devel@m.gmane.org>) id 1P3kmT-00057w-Jr
	for qemu-devel@nongnu.org; Thu, 07 Oct 2010 09:20:45 +0200
Received: from nat-pool-brq-t.redhat.com ([209.132.186.34])
	by main.gmane.org with esmtp (Gmexim 0.1 (Debian))
	id 1AlnuQ-0007hv-00
	for <qemu-devel@nongnu.org>; Thu, 07 Oct 2010 09:20:45 +0200
Received: from pbonzini by nat-pool-brq-t.redhat.com with local (Gmexim 0.1
	(Debian)) id 1AlnuQ-0007hv-00
	for <qemu-devel@nongnu.org>; Thu, 07 Oct 2010 09:20:45 +0200
From: Paolo Bonzini <pbonzini@redhat.com>
Date: Thu, 07 Oct 2010 09:20:37 +0200
Message-ID: <4CAD74C5.5060102@redhat.com>
References: <AANLkTimu7PP5qjZNUuzcTHxwEDOW081jnLFZPJQw-jR+@mail.gmail.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
In-Reply-To: <AANLkTimu7PP5qjZNUuzcTHxwEDOW081jnLFZPJQw-jR+@mail.gmail.com>
Subject: [Qemu-devel] Re: [PATCH 04/11] lsi53c895a: avoid a write only
	variable
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: qemu-devel@nongnu.org

On 10/06/2010 11:32 PM, Blue Swirl wrote:
> Compiling with GCC 4.6.0 20100925 produced a warning:
> /src/qemu/hw/lsi53c895a.c: In function 'lsi_do_msgout':
> /src/qemu/hw/lsi53c895a.c:848:9: error: variable 'len' set but not
> used [-Werror=unused-but-set-variable]
>
> Fix by making the variable declaration and its uses also conditional
> to debug definition.

NACK, this uglifies the code and loses track of _what_ is that msgbyte 
we're reading.

Paolo