From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from [140.186.70.92] (port=34316 helo=eggs.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1P3kzN-0002Yp-Sj
	for qemu-devel@nongnu.org; Thu, 07 Oct 2010 03:34:08 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <paolo.bonzini@gmail.com>) id 1P3kst-0006UN-R7
	for qemu-devel@nongnu.org; Thu, 07 Oct 2010 03:27:24 -0400
Received: from mail-iw0-f173.google.com ([209.85.214.173]:55613)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <paolo.bonzini@gmail.com>) id 1P3kst-0006U8-N4
	for qemu-devel@nongnu.org; Thu, 07 Oct 2010 03:27:23 -0400
Received: by iwn38 with SMTP id 38so17737iwn.4
	for <qemu-devel@nongnu.org>; Thu, 07 Oct 2010 00:27:23 -0700 (PDT)
Sender: Paolo Bonzini <paolo.bonzini@gmail.com>
Message-ID: <4CAD7657.8080400@redhat.com>
Date: Thu, 07 Oct 2010 09:27:19 +0200
From: Paolo Bonzini <pbonzini@redhat.com>
MIME-Version: 1.0
References: <AANLkTinWu7ABrSP9EVZFeC==+ZS+qDOur8rAPNjdzo6i@mail.gmail.com>
In-Reply-To: <AANLkTinWu7ABrSP9EVZFeC==+ZS+qDOur8rAPNjdzo6i@mail.gmail.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Subject: [Qemu-devel] Re: [PATCH 09/11] i386: avoid a write only variable
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Blue Swirl <blauwirbel@gmail.com>
Cc: qemu-devel <qemu-devel@nongnu.org>

On 10/06/2010 11:34 PM, Blue Swirl wrote:
> Compiling with GCC 4.6.0 20100925 produced warnings:
> /src/qemu/target-i386/op_helper.c: In function 'switch_tss':
> /src/qemu/target-i386/op_helper.c:283:53: error: variable 'new_trap'
> set but not used [-Werror=unused-but-set-variable]
>
> Fix by deleting the variable.

Again, this warning tells us the emulation is incorrect, so it's wrong 
to remove it.

Paolo