From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from [140.186.70.92] (port=33658 helo=eggs.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1P3kz8-0002M5-Fu
	for qemu-devel@nongnu.org; Thu, 07 Oct 2010 03:34:04 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <paolo.bonzini@gmail.com>) id 1P3kul-0006yx-J7
	for qemu-devel@nongnu.org; Thu, 07 Oct 2010 03:29:20 -0400
Received: from mail-iw0-f173.google.com ([209.85.214.173]:58393)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <paolo.bonzini@gmail.com>) id 1P3kul-0006ys-G0
	for qemu-devel@nongnu.org; Thu, 07 Oct 2010 03:29:19 -0400
Received: by iwn38 with SMTP id 38so20161iwn.4
	for <qemu-devel@nongnu.org>; Thu, 07 Oct 2010 00:29:19 -0700 (PDT)
Sender: Paolo Bonzini <paolo.bonzini@gmail.com>
Message-ID: <4CAD76C2.1060605@redhat.com>
Date: Thu, 07 Oct 2010 09:29:06 +0200
From: Paolo Bonzini <pbonzini@redhat.com>
MIME-Version: 1.0
References: <AANLkTik+sX3YdpzYt4D2vVoMZ8jW2i2M3V=9cSXkN4jw@mail.gmail.com>
In-Reply-To: <AANLkTik+sX3YdpzYt4D2vVoMZ8jW2i2M3V=9cSXkN4jw@mail.gmail.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Subject: [Qemu-devel] Re: [PATCH 11/11] mips: avoid write only variables
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Blue Swirl <blauwirbel@gmail.com>
Cc: qemu-devel <qemu-devel@nongnu.org>

On 10/06/2010 11:34 PM, Blue Swirl wrote:
> Compiling with GCC 4.6.0 20100925 produced a lot of warnings like:
> /src/qemu/target-mips/translate.c: In function 'gen_ld':
> /src/qemu/target-mips/translate.c:1039:17: error: variable 'opn' set
> but not used [-Werror=unused-but-set-variable]
>
> Fix by making the variable declarations and uses conditional to debugging.

What about a set_opn macro instead of this one-off "D" idiom?

Paolo