From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from [140.186.70.92] (port=46673 helo=eggs.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1P3rCa-0004qd-FE
	for qemu-devel@nongnu.org; Thu, 07 Oct 2010 10:12:09 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <Jes.Sorensen@redhat.com>) id 1P3rCY-0002ix-Qt
	for qemu-devel@nongnu.org; Thu, 07 Oct 2010 10:12:08 -0400
Received: from mx1.redhat.com ([209.132.183.28]:4063)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <Jes.Sorensen@redhat.com>) id 1P3rCY-0002iY-CZ
	for qemu-devel@nongnu.org; Thu, 07 Oct 2010 10:12:06 -0400
Received: from int-mx09.intmail.prod.int.phx2.redhat.com
	(int-mx09.intmail.prod.int.phx2.redhat.com [10.5.11.22])
	by mx1.redhat.com (8.13.8/8.13.8) with ESMTP id o97EC51H006566
	(version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK)
	for <qemu-devel@nongnu.org>; Thu, 7 Oct 2010 10:12:05 -0400
Message-ID: <4CADD533.30404@redhat.com>
Date: Thu, 07 Oct 2010 16:12:03 +0200
From: Jes Sorensen <Jes.Sorensen@redhat.com>
MIME-Version: 1.0
Subject: Re: [Qemu-devel] [PATCH 4/5] Switch migrate_set_speed() to take an
	'o' argument rather than a float.
References: <1284648749-18479-1-git-send-email-Jes.Sorensen@redhat.com>	<1284648749-18479-5-git-send-email-Jes.Sorensen@redhat.com>
	<m3d3ryji48.fsf@blackfin.pond.sub.org>
In-Reply-To: <m3d3ryji48.fsf@blackfin.pond.sub.org>
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 7bit
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Markus Armbruster <armbru@redhat.com>
Cc: pbonzini@redhat.com, qemu-devel@nongnu.org

On 09/28/10 12:08, Markus Armbruster wrote:
> Jes.Sorensen@redhat.com writes:
>> diff --git a/qemu-monitor.hx b/qemu-monitor.hx
>> index 49bcd8d..7f58fb2 100644
>> --- a/qemu-monitor.hx
>> +++ b/qemu-monitor.hx
>> @@ -1093,7 +1093,7 @@ EQMP
>>  
>>      {
>>          .name       = "migrate_set_speed",
>> -        .args_type  = "value:f",
>> +        .args_type  = "value:o",
>>          .params     = "value",
>>          .help       = "set maximum speed (in bytes) for migrations",
>>          .user_print = monitor_user_noop,
> 
> Doesn't this change the interpretation of "42" from 42 to (42 << 20)?

It was always so on the command line that a number without a specifier
meant MB. If the monitor defaulted to bytes it will get ugly to support
both defaults in common code.

Cheers,
Jes