From: Paolo Bonzini <pbonzini@redhat.com>
To: Jes.Sorensen@redhat.com
Cc: qemu-devel@nongnu.org, armbru@redhat.com
Subject: [Qemu-devel] Re: [PATCH 3/6] Add more error handling to strtosz()
Date: Thu, 07 Oct 2010 17:52:01 +0200 [thread overview]
Message-ID: <4CADECA1.1010309@redhat.com> (raw)
In-Reply-To: <1286463710-28262-4-git-send-email-Jes.Sorensen@redhat.com>
On 10/07/2010 05:01 PM, Jes.Sorensen@redhat.com wrote:
> + if (tmpval > ~(size_t)0)
Since -1 is an error, this needs to be >=.
Paolo
next prev parent reply other threads:[~2010-10-07 15:52 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-10-07 15:01 [Qemu-devel] [PATCH v3 0/6] Introduce strtosz and make use of it Jes.Sorensen
2010-10-07 15:01 ` [Qemu-devel] [PATCH 1/6] Introduce strtosz() library function to convert a string to a byte count Jes.Sorensen
2010-10-07 15:01 ` [Qemu-devel] [PATCH 2/6] Support human unit formats in strtosz, eg. 1.0G Jes.Sorensen
2010-10-07 15:01 ` [Qemu-devel] [PATCH 3/6] Add more error handling to strtosz() Jes.Sorensen
2010-10-07 15:52 ` Paolo Bonzini [this message]
2010-10-07 15:01 ` [Qemu-devel] [PATCH 4/6] Add support for 'o' octet (bytes) format as monitor parameter Jes.Sorensen
2010-10-07 15:01 ` [Qemu-devel] [PATCH 5/6] Switch migrate_set_speed() to take an 'o' argument rather than a float Jes.Sorensen
2010-10-07 16:03 ` [Qemu-devel] " Paolo Bonzini
2010-10-08 8:50 ` Jes Sorensen
2010-10-07 15:01 ` [Qemu-devel] [PATCH 6/6] Remove obsolete 'f' double parameter type Jes.Sorensen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4CADECA1.1010309@redhat.com \
--to=pbonzini@redhat.com \
--cc=Jes.Sorensen@redhat.com \
--cc=armbru@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).