From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from [140.186.70.92] (port=43560 helo=eggs.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1P3slN-00015Y-1h
	for qemu-devel@nongnu.org; Thu, 07 Oct 2010 11:52:10 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <pbonzini@redhat.com>) id 1P3slM-0002lP-1L
	for qemu-devel@nongnu.org; Thu, 07 Oct 2010 11:52:08 -0400
Received: from mx1.redhat.com ([209.132.183.28]:18394)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <pbonzini@redhat.com>) id 1P3slL-0002l5-QU
	for qemu-devel@nongnu.org; Thu, 07 Oct 2010 11:52:07 -0400
Message-ID: <4CADECA1.1010309@redhat.com>
Date: Thu, 07 Oct 2010 17:52:01 +0200
From: Paolo Bonzini <pbonzini@redhat.com>
MIME-Version: 1.0
References: <1286463710-28262-1-git-send-email-Jes.Sorensen@redhat.com>
	<1286463710-28262-4-git-send-email-Jes.Sorensen@redhat.com>
In-Reply-To: <1286463710-28262-4-git-send-email-Jes.Sorensen@redhat.com>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
Subject: [Qemu-devel] Re: [PATCH 3/6] Add more error handling to strtosz()
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Jes.Sorensen@redhat.com
Cc: qemu-devel@nongnu.org, armbru@redhat.com

On 10/07/2010 05:01 PM, Jes.Sorensen@redhat.com wrote:
> +    if (tmpval > ~(size_t)0)

Since -1 is an error, this needs to be >=.

Paolo