From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from [140.186.70.92] (port=48516 helo=eggs.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1P3wA2-00082a-PQ
	for qemu-devel@nongnu.org; Thu, 07 Oct 2010 15:29:52 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <kraxel@redhat.com>) id 1P3wA1-00041q-Fd
	for qemu-devel@nongnu.org; Thu, 07 Oct 2010 15:29:50 -0400
Received: from mx1.redhat.com ([209.132.183.28]:27980)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <kraxel@redhat.com>) id 1P3wA1-00041a-6N
	for qemu-devel@nongnu.org; Thu, 07 Oct 2010 15:29:49 -0400
Message-ID: <4CAE1FA1.9020903@redhat.com>
Date: Thu, 07 Oct 2010 21:29:37 +0200
From: Gerd Hoffmann <kraxel@redhat.com>
MIME-Version: 1.0
Subject: Re: [Qemu-devel] [PATCH 2/5] spice: make compression configurable.
References: <1286438126-11250-1-git-send-email-kraxel@redhat.com>
	<1286438126-11250-3-git-send-email-kraxel@redhat.com>
	<AANLkTi=LnJ0dY7pEGRxdgw5YoG1KTUEh4AcmCQ5MEUOO@mail.gmail.com>
In-Reply-To: <AANLkTi=LnJ0dY7pEGRxdgw5YoG1KTUEh4AcmCQ5MEUOO@mail.gmail.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Blue Swirl <blauwirbel@gmail.com>
Cc: Yonit Halperin <yhalperi@redhat.com>, qemu-devel@nongnu.org

On 10/07/10 20:12, Blue Swirl wrote:
> On Thu, Oct 7, 2010 at 7:55 AM, Gerd Hoffmann<kraxel@redhat.com>  wrote:
>> From: Yonit Halperin<yhalperi@redhat.com>
>>
>
> No description?

Detailed description comes here:

>> --- a/qemu-options.hx
>> +++ b/qemu-options.hx
>> @@ -704,6 +704,15 @@ The x509 file names can also be configured individually.
>>   @item tls-ciphers=<list>
>>   Specify which ciphers to use.
>>
>> +@item image-compression=[auto_glz|auto_lz|quic|glz|lz|off]
>> +Configure image compression (lossless).
>> +Default is auto_glz.
>> +
>> +@item jpeg-wan-compression=[auto|never|allways]
>> +@item zlib-glz-wan-compression=[auto|never|allways]
>
> 'allways' does not match what the code uses:
>
>> +    [ SPICE_WAN_COMPRESSION_ALWAYS ] = "always",

Good catch, will fix.

thanks,
   Gerd