From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from [140.186.70.92] (port=58474 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1P48ee-0005LO-W7 for qemu-devel@nongnu.org; Fri, 08 Oct 2010 04:50:17 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1P48ed-00046x-SO for qemu-devel@nongnu.org; Fri, 08 Oct 2010 04:50:16 -0400 Received: from mx1.redhat.com ([209.132.183.28]:33912) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1P48ed-00046q-KG for qemu-devel@nongnu.org; Fri, 08 Oct 2010 04:50:15 -0400 Message-ID: <4CAEDB3F.9080703@redhat.com> Date: Fri, 08 Oct 2010 10:50:07 +0200 From: Jes Sorensen MIME-Version: 1.0 References: <1286463710-28262-1-git-send-email-Jes.Sorensen@redhat.com> <1286463710-28262-6-git-send-email-Jes.Sorensen@redhat.com> <4CADEF6D.3010706@redhat.com> In-Reply-To: <4CADEF6D.3010706@redhat.com> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Subject: [Qemu-devel] Re: [PATCH 5/6] Switch migrate_set_speed() to take an 'o' argument rather than a float. List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Paolo Bonzini Cc: qemu-devel@nongnu.org, armbru@redhat.com On 10/07/10 18:03, Paolo Bonzini wrote: > On 10/07/2010 05:01 PM, Jes.Sorensen@redhat.com wrote: >> diff --git a/hmp-commands.hx b/hmp-commands.hx >> index 81999aa..95bdb91 100644 >> --- a/hmp-commands.hx >> +++ b/hmp-commands.hx >> @@ -754,7 +754,7 @@ ETEXI >> >> { >> .name = "migrate_set_speed", >> - .args_type = "value:f", >> + .args_type = "value:o", >> .params = "value", >> .help = "set maximum speed (in bytes) for migrations", > ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ > > Is this still accurate? > > Alternatively, you said it's a mess to distinguish the defaults on the > command line and the monitor, but is it harder than the attached patch? I guess that depends on how you look at it, but I guess I could improve the error message to make it clearer. Cheers, Jes