From: Paolo Bonzini <pbonzini@redhat.com>
To: Blue Swirl <blauwirbel@gmail.com>
Cc: Markus Armbruster <armbru@redhat.com>, qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] Re: [PATCH 04/11] lsi53c895a: avoid a write only variable
Date: Fri, 08 Oct 2010 18:11:11 +0200 [thread overview]
Message-ID: <4CAF429F.5010303@redhat.com> (raw)
In-Reply-To: <AANLkTimNhgKrHNCk+8zb0cAqevf+0U1ZMkG+ojXpPeFB@mail.gmail.com>
On 10/07/2010 08:53 PM, Blue Swirl wrote:
> On Thu, Oct 7, 2010 at 9:20 AM, Markus Armbruster<armbru@redhat.com> wrote:
>> Paolo Bonzini<pbonzini@redhat.com> writes:
>>
>>> On 10/06/2010 11:32 PM, Blue Swirl wrote:
>>>> Compiling with GCC 4.6.0 20100925 produced a warning:
>>>> /src/qemu/hw/lsi53c895a.c: In function 'lsi_do_msgout':
>>>> /src/qemu/hw/lsi53c895a.c:848:9: error: variable 'len' set but not
>>>> used [-Werror=unused-but-set-variable]
>>>>
>>>> Fix by making the variable declaration and its uses also conditional
>>>> to debug definition.
>>>
>>> NACK, this uglifies the code and loses track of _what_ is that msgbyte
>>> we're reading.
>
> That information could be saved by adding a comment, I used that
> approach for vmstate.c.
Yes, that's fine for vmstate.c, but here you are also uselessly
duplicating the code. (void) len is good though. I suggest doing the
same for i386 too (and there you could put a reference to the manual).
Paolo
prev parent reply other threads:[~2010-10-08 16:29 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-10-06 21:32 [Qemu-devel] [PATCH 04/11] lsi53c895a: avoid a write only variable Blue Swirl
2010-10-07 7:20 ` [Qemu-devel] " Paolo Bonzini
2010-10-07 9:20 ` Markus Armbruster
2010-10-07 18:53 ` Blue Swirl
2010-10-08 16:11 ` Paolo Bonzini [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4CAF429F.5010303@redhat.com \
--to=pbonzini@redhat.com \
--cc=armbru@redhat.com \
--cc=blauwirbel@gmail.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).