From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from [140.186.70.92] (port=49116 helo=eggs.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1P4FpL-0002wc-E4
	for qemu-devel@nongnu.org; Fri, 08 Oct 2010 12:29:51 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <pbonzini@redhat.com>) id 1P4FXS-0004Nj-K7
	for qemu-devel@nongnu.org; Fri, 08 Oct 2010 12:11:19 -0400
Received: from mx1.redhat.com ([209.132.183.28]:30486)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <pbonzini@redhat.com>) id 1P4FXS-0004NL-DM
	for qemu-devel@nongnu.org; Fri, 08 Oct 2010 12:11:18 -0400
Message-ID: <4CAF429F.5010303@redhat.com>
Date: Fri, 08 Oct 2010 18:11:11 +0200
From: Paolo Bonzini <pbonzini@redhat.com>
MIME-Version: 1.0
Subject: Re: [Qemu-devel] Re: [PATCH 04/11] lsi53c895a: avoid a write only
	variable
References: <AANLkTimu7PP5qjZNUuzcTHxwEDOW081jnLFZPJQw-jR+@mail.gmail.com>
	<4CAD74C5.5060102@redhat.com>
	<m37hhuqrzy.fsf@blackfin.pond.sub.org>
	<AANLkTimNhgKrHNCk+8zb0cAqevf+0U1ZMkG+ojXpPeFB@mail.gmail.com>
In-Reply-To: <AANLkTimNhgKrHNCk+8zb0cAqevf+0U1ZMkG+ojXpPeFB@mail.gmail.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Blue Swirl <blauwirbel@gmail.com>
Cc: Markus Armbruster <armbru@redhat.com>, qemu-devel@nongnu.org

On 10/07/2010 08:53 PM, Blue Swirl wrote:
> On Thu, Oct 7, 2010 at 9:20 AM, Markus Armbruster<armbru@redhat.com>  wrote:
>> Paolo Bonzini<pbonzini@redhat.com>  writes:
>>
>>> On 10/06/2010 11:32 PM, Blue Swirl wrote:
>>>> Compiling with GCC 4.6.0 20100925 produced a warning:
>>>> /src/qemu/hw/lsi53c895a.c: In function 'lsi_do_msgout':
>>>> /src/qemu/hw/lsi53c895a.c:848:9: error: variable 'len' set but not
>>>> used [-Werror=unused-but-set-variable]
>>>>
>>>> Fix by making the variable declaration and its uses also conditional
>>>> to debug definition.
>>>
>>> NACK, this uglifies the code and loses track of _what_ is that msgbyte
>>> we're reading.
>
> That information could be saved by adding a comment, I used that
> approach for vmstate.c.

Yes, that's fine for vmstate.c, but here you are also uselessly 
duplicating the code.  (void) len is good though.  I suggest doing the 
same for i386 too (and there you could put a reference to the manual).

Paolo