From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from [140.186.70.92] (port=40732 helo=eggs.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1P5I8T-0006PR-9L
	for qemu-devel@nongnu.org; Mon, 11 Oct 2010 09:09:50 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <paolo.bonzini@gmail.com>) id 1P5I8S-0003Q8-7H
	for qemu-devel@nongnu.org; Mon, 11 Oct 2010 09:09:49 -0400
Received: from mail-yw0-f45.google.com ([209.85.213.45]:36511)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <paolo.bonzini@gmail.com>) id 1P5I8S-0003Q0-4p
	for qemu-devel@nongnu.org; Mon, 11 Oct 2010 09:09:48 -0400
Received: by ywh1 with SMTP id 1so652384ywh.4
	for <qemu-devel@nongnu.org>; Mon, 11 Oct 2010 06:09:47 -0700 (PDT)
Sender: Paolo Bonzini <paolo.bonzini@gmail.com>
Message-ID: <4CB30C97.9040404@redhat.com>
Date: Mon, 11 Oct 2010 15:09:43 +0200
From: Paolo Bonzini <pbonzini@redhat.com>
MIME-Version: 1.0
References: <m3zkuksxgv.fsf@blackfin.pond.sub.org>
In-Reply-To: <m3zkuksxgv.fsf@blackfin.pond.sub.org>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
Subject: [Qemu-devel] Re: [PATCH] Suppress warning: zero-length gnu_printf
	format string
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Markus Armbruster <armbru@redhat.com>
Cc: Blue Swirl <blauwirbel@gmail.com>, qemu-devel@nongnu.org

On 10/11/2010 02:52 PM, Markus Armbruster wrote:
> Warns about this line in check-qjson.c:
>      QObject *obj = qobject_from_json("");
>
> The obvious fix (add -Wno-format-zero-length to gcc_flags) doesn't
> work, because -Wall switches it on again.  Fix by putting configured
> flags last.
>
> Signed-off-by: Markus Armbruster<armbru@redhat.com>
> ---
>   configure |    5 +++--
>   1 files changed, 3 insertions(+), 2 deletions(-)
>
> diff --git a/configure b/configure
> index d303061..3a12f92 100755
> --- a/configure
> +++ b/configure
> @@ -146,7 +146,8 @@ QEMU_CFLAGS="-I. -I\$(SRC_PATH) $QEMU_CFLAGS"
>   LDFLAGS="-g $LDFLAGS"
>
>   gcc_flags="-Wold-style-declaration -Wold-style-definition -Wtype-limits"
> -gcc_flags="-Wformat-security -Wformat-y2k -Winit-self -Wignored-qualifiers $gcc_flags"
> +gcc_flags="-Wformat-security -Wformat-y2k -Wno-format-zero-length $gcc_flags"
> +gcc_flags="-Winit-self -Wignored-qualifiers $gcc_flags"
>   gcc_flags="-Wmissing-include-dirs -Wempty-body -Wnested-externs $gcc_flags"
>   gcc_flags="-fstack-protector-all $gcc_flags"
>   cat>  $TMPC<<  EOF
> @@ -154,7 +155,7 @@ int main(void) { return 0; }
>   EOF
>   for flag in $gcc_flags; do
>       if compile_prog "-Werror $QEMU_CFLAGS" "-Werror $flag" ; then
> -	QEMU_CFLAGS="$flag $QEMU_CFLAGS"
> +	QEMU_CFLAGS="$QEMU_CFLAGS $flag"
>       fi
>   done
>

Acked-By: Paolo Bonzini <pbonzini@redhat.com>

Paolo