From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from [140.186.70.92] (port=37075 helo=eggs.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1P5eqY-0003SC-G9
	for qemu-devel@nongnu.org; Tue, 12 Oct 2010 09:24:51 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <anthony@codemonkey.ws>) id 1P5eqX-0000fh-Fe
	for qemu-devel@nongnu.org; Tue, 12 Oct 2010 09:24:50 -0400
Received: from mail-iw0-f173.google.com ([209.85.214.173]:37665)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <anthony@codemonkey.ws>) id 1P5eqX-0000fS-BX
	for qemu-devel@nongnu.org; Tue, 12 Oct 2010 09:24:49 -0400
Received: by iwn34 with SMTP id 34so3620100iwn.4
	for <qemu-devel@nongnu.org>; Tue, 12 Oct 2010 06:24:48 -0700 (PDT)
Message-ID: <4CB4619D.1010101@codemonkey.ws>
Date: Tue, 12 Oct 2010 08:24:45 -0500
From: Anthony Liguori <anthony@codemonkey.ws>
MIME-Version: 1.0
Subject: Re: [Qemu-devel] [PATCH 0/2] usb-ccid device (v2)
References: <1286888309-4493-1-git-send-email-alevy@redhat.com>
In-Reply-To: <1286888309-4493-1-git-send-email-alevy@redhat.com>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Alon Levy <alevy@redhat.com>
Cc: qemu-devel@nongnu.org

On 10/12/2010 07:58 AM, Alon Levy wrote:
> This patch adds a new device, it is described in full in the second patch
> intro and also in the documentation in docs. In brief it provides a standard
> smart card reader device.
>
> The first patch is the configure change and docs.
> The second patch contains the actual device, I couldn't figure out a good
> way to split it to ease review.
>
> v2 changed:
>   * all QSIMPLEQ turned into fixed sized rings
>   * all allocated buffers turned into fixed size buffers
>   * added migration support
>   * added a message to tell client qemu has migrated to ip:port
>    * for lack of monitor commands ip:port are 0:0, which causes the updated
>     vscclient to connect to one port higher on the same host. will add monitor
>     commands in a separate patch. tested with current setup.
>    

This is way too much magic to live within a device.  Devices manage 
reconnecting themselves during migration.  When you create the 
destination qemu instance, you specify what to connect to.

IOW,

On the source:

qemu -chardev tcp:localhost:1025,id=foo -usbdevice ccid,chardev=foo ...

On the destination:

qemu -chardev tcp:localhost:1026,id=foo -usbdevice ccid,chardev=foo 
-incoming tcp:0.0.0.0:1024 ...

A connection happens when the device is created.

But now I'm even further confused then when I first reviewed it..  If 
you're now supporting migration, does that mean that you're relying on 
the daemon to emulate the device?

Regards,

Anthony Liguori

> Alon Levy (2):
>    usb-ccid: add CCID device. add configure option.
>    usb-ccid: add CCID device (device itself)
>
>   Makefile.objs      |    1 +
>   configure          |   12 +
>   docs/usb-ccid.txt  |  115 +++++
>   hw/usb-ccid.c      | 1376 ++++++++++++++++++++++++++++++++++++++++++++++++++++
>   hw/vscard_common.h |  131 +++++
>   5 files changed, 1635 insertions(+), 0 deletions(-)
>   create mode 100644 docs/usb-ccid.txt
>   create mode 100644 hw/usb-ccid.c
>   create mode 100644 hw/vscard_common.h
>
>