From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from [140.186.70.92] (port=40979 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1P5fsJ-0007qX-UQ for qemu-devel@nongnu.org; Tue, 12 Oct 2010 10:30:45 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1P5fsI-0003ac-UF for qemu-devel@nongnu.org; Tue, 12 Oct 2010 10:30:43 -0400 Received: from mail-qy0-f173.google.com ([209.85.216.173]:49774) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1P5fsI-0003aY-R9 for qemu-devel@nongnu.org; Tue, 12 Oct 2010 10:30:42 -0400 Received: by qyk36 with SMTP id 36so717077qyk.4 for ; Tue, 12 Oct 2010 07:30:41 -0700 (PDT) Message-ID: <4CB4710D.8050502@codemonkey.ws> Date: Tue, 12 Oct 2010 09:30:37 -0500 From: Anthony Liguori MIME-Version: 1.0 Subject: Re: [Qemu-devel] [PATCH 00/39] Make configure command line autoconf-compatible References: <1286888457-5033-1-git-send-email-pbonzini@redhat.com> <4CB46213.2040000@redhat.com> In-Reply-To: Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: malc Cc: Paolo Bonzini , qemu-devel@nongnu.org On 10/12/2010 08:32 AM, malc wrote: > On Tue, 12 Oct 2010, Paolo Bonzini wrote: > > >> On 10/12/2010 03:22 PM, malc wrote: >> >>>> 19 files changed, 3729 insertions(+), 456 deletions(-) >>>> >>> I don't think the explanation above justified net plus of 3273 lines of new >>> code. >>> >> The part you forgot to quote is: >> > Yes, failed to notice that, sorry. > > >> >>> Makefile | 54 +- >>> Makefile.dis | 6 +- >>> Makefile.hw | 8 +- >>> Makefile.objs | 4 +- >>> Makefile.target | 32 +- >>> Makefile.user | 6 +- >>> bsd-user/main.c | 10 +- >>> config.guess | 1502 ++++++++++++++++++++++++++++++++++++++ >>> config.sub | 1731 >>> ++++++++++++++++++++++++++++++++++++++++++++ >>> configure | 757 ++++++++++--------- >>> create_config | 5 +- >>> darwin-user/machload.c | 12 +- >>> darwin-user/main.c | 6 +- >>> darwin-user/syscall.c | 2 +- >>> linux-user/main.c | 10 +- >>> pc-bios/optionrom/Makefile | 8 +- >>> rules.mak | 10 +- >>> tests/Makefile | 16 +- >>> tests/cris/Makefile | 6 +- >>> 19 files changed, 3729 insertions(+), 456 deletions(-) >>> >> All these lines are in config.guess and config.sub that are shared with all >> projects using Autotools and do not really need to be considered. >> >> It's 40 lines of new code, 33 of which are in configure's help message. >> I think there's a fair bit of value in looking like autoconf but a 39 patch series is a bit to digest at once. I'll try to do a thorough review but I'd suggest keeping patch series down to about 20 patches whenever possible and do multiple rounds as necessary. Regards, Anthony Liguori >> Paolo >> >> >