From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from [140.186.70.92] (port=45720 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1P5gps-0002b9-OU for qemu-devel@nongnu.org; Tue, 12 Oct 2010 11:32:20 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1P5gpr-0006KZ-6g for qemu-devel@nongnu.org; Tue, 12 Oct 2010 11:32:16 -0400 Received: from mx1.redhat.com ([209.132.183.28]:16788) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1P5gpq-0006KA-WB for qemu-devel@nongnu.org; Tue, 12 Oct 2010 11:32:15 -0400 Message-ID: <4CB47F78.2010102@redhat.com> Date: Tue, 12 Oct 2010 17:32:08 +0200 From: Paolo Bonzini MIME-Version: 1.0 Subject: Re: [Qemu-devel] [PATCH 08/39] provide portable sizeof(long) test References: <1286888457-5033-1-git-send-email-pbonzini@redhat.com> <1286888457-5033-9-git-send-email-pbonzini@redhat.com> <4CB47129.1090202@redhat.com> <4CB47348.1050700@redhat.com> <4CB47796.1010101@redhat.com> In-Reply-To: Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: malc Cc: qemu-devel@nongnu.org On 10/12/2010 05:12 PM, malc wrote: > Bottom line: QEMU assumes that long is large enough to hold a pointer, > this assumption is wrong, and your patch is wrong (not because it > miscalculates size of ABI long) but because of the assumptions current > code has. Whether two wrongs makes right is an open question, currently > Win64 isnot supported in any shape or form, even though Filip Navarra > once did a port[1] which never went into mainline. > > [1] http://marc.info/?l=qemu-devel&m=124912692531724&w=2 His port apparently is fine with HOST_LONG_BITS == sizeof(void *), I'll adjust for v2. Paolo