From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from [140.186.70.92] (port=44391 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1P5vZH-00071u-0w for qemu-devel@nongnu.org; Wed, 13 Oct 2010 03:16:11 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1P5vZC-0007Aa-Cr for qemu-devel@nongnu.org; Wed, 13 Oct 2010 03:16:06 -0400 Received: from mx1.redhat.com ([209.132.183.28]:19144) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1P5vZC-0007AG-6T for qemu-devel@nongnu.org; Wed, 13 Oct 2010 03:16:02 -0400 Message-ID: <4CB55CAE.1030204@redhat.com> Date: Wed, 13 Oct 2010 09:15:58 +0200 From: Paolo Bonzini MIME-Version: 1.0 Subject: Re: [Qemu-devel] [PATCH 04/39] fix sparse support (?) References: <1286888457-5033-1-git-send-email-pbonzini@redhat.com> <1286888457-5033-5-git-send-email-pbonzini@redhat.com> In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Blue Swirl Cc: qemu-devel@nongnu.org On 10/12/2010 09:02 PM, Blue Swirl wrote: > On Tue, Oct 12, 2010 at 1:00 PM, Paolo Bonzini wrote: >> I didn't test with sparse, but the old code using += before a variable >> was set was wrong. Sparse support should probably be ripped out or >> redone, but this at least keeps some sanity. >> >> Signed-off-by: Paolo Bonzini >> --- >> configure | 10 +++++----- >> 1 files changed, 5 insertions(+), 5 deletions(-) >> >> diff --git a/configure b/configure >> index 9e2ae71..6b5c323 100755 >> --- a/configure >> +++ b/configure >> @@ -2617,17 +2617,17 @@ echo "INSTALL_DATA=$install -m0644 -p">> $config_host_mak >> echo "INSTALL_PROG=$install -m0755 -p">> $config_host_mak >> echo "CC=$cc">> $config_host_mak >> echo "HOST_CC=$host_cc">> $config_host_mak >> -if test "$sparse" = "yes" ; then >> - echo "CC := REAL_CC=\"\$(CC)\" cgcc">> $config_host_mak >> - echo "HOST_CC := REAL_CC=\"\$(HOST_CC)\" cgcc">> $config_host_mak >> - echo "QEMU_CFLAGS += -Wbitwise -Wno-transparent-union -Wno-old-initializer -Wno-non-pointer-null">> $config_host_mak >> -fi >> echo "AR=$ar">> $config_host_mak >> echo "OBJCOPY=$objcopy">> $config_host_mak >> echo "LD=$ld">> $config_host_mak >> echo "WINDRES=$windres">> $config_host_mak >> echo "CFLAGS=$CFLAGS">> $config_host_mak >> echo "QEMU_CFLAGS=$QEMU_CFLAGS">> $config_host_mak >> +if test "$sparse" = "yes" ; then >> + echo "CC := REAL_CC=\"\$(CC)\" cgcc">> $config_host_mak >> + echo "HOST_CC := REAL_CC=\"\$(HOST_CC)\" cgcc">> $config_host_mak >> + echo "QEMU_CFLAGS += -Wbitwise -Wno-transparent-union -Wno-old-initializer -Wno-non-pointer-null">> $config_host_mak > > Could these be added to general list of compiler flags that are > checked and used automatically if the compiler accepts them? The problem is that the tests are done with the REAL_CC, not with sparse, so the tests will not pass. I will look at it some time, but for now I just wanted to avoid WTF moments for reviewers of later patches. Paolo